Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Upgrade rubocop to version 0.61.1 #50

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Upgrade rubocop to version 0.61.1 #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
509174a
Update rubocop to version 0.61.1
depfu[bot] Dec 11, 2018
435918c
Rubocop updates (@ruebot)
ruebot Dec 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ RSpec/MultipleExpectations:
RSpec/NestedGroups:
Max: 4

RSpec/DescribeClass:
Enabled: false

Rails/TimeZone:
Exclude:
- 'app/models/concerns/warclight/solr_document.rb' #Come back to this later
Expand All @@ -66,9 +69,19 @@ Style/Documentation:
- 'spec/**/*'
- 'lib/warclight.rb'

Style/ExpandPathArguments:
Exclude:
- warclight.gemspec
- lib/generators/warclight/install_generator.rb
- lib/generators/warclight/update_generator.rb

Bundler/DuplicatedGem:
Enabled: false

Lint/UselessAssignment:
Exclude:
- 'app/models/concerns/warclight/solr_document.rb' #Come back to this later

Style/RescueStandardError:
Exclude:
- app/helpers/warclight_helper.rb
1 change: 1 addition & 0 deletions tasks/warclight.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,6 @@ namespace :warclight do
system('curl -o ".internal_test_app/tmp/warc-indexer.jar" "http://alpha.library.yorku.ca/warc-indexer.jar"')
system('java -Djava.io.tmpdir=.internal_test_app/tmp -jar .internal_test_app/tmp/warc-indexer.jar -c .internal_test_app/solr/warclight_warc-indexer.conf -i "York University Libraries" -n "Test Collection" -u "12345" -s http://localhost:8983/solr/blacklight-core spec/fixtures/warcs/*.gz')
system('curl "http://localhost:8983/solr/blacklight-core/update?commit=true&openSearcher=true"')
# rubocop:enable Metrics/LineLength
end
end
2 changes: 1 addition & 1 deletion warclight.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'poltergeist'
s.add_development_dependency 'rake', '~> 12.0'
s.add_development_dependency 'rspec-rails', '~> 3.0'
s.add_development_dependency 'rubocop', '~> 0.48.1'
s.add_development_dependency 'rubocop', '~> 0.61.1'
s.add_development_dependency 'rubocop-rspec', '~> 1.15.0'
s.add_development_dependency 'simplecov'
s.add_development_dependency 'solr_wrapper'
Expand Down