Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotbackup Deadlock and Consistency fixes. #18928

Merged
merged 57 commits into from
Jul 14, 2023
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
978a46b
Acquire lock during commit. Not during the whole trx.
maierlars May 10, 2023
b93dcc5
Also send lock requests to coordinators.
maierlars May 10, 2023
ca33b89
Only lock coordinators.
maierlars May 11, 2023
f51481f
Hold hotbackup read lock during intermediate commit.
maierlars May 11, 2023
33dda21
Adding more information to error message.
maierlars May 11, 2023
5acf450
Fixing c++ test.
maierlars May 11, 2023
3bfcb12
Remove log devel.
maierlars May 11, 2023
4037b1a
Remove log devel.
maierlars May 11, 2023
615e8c1
Simplify test.
neunhoef May 12, 2023
551e3a3
Add tick to search snapshot.
maierlars May 31, 2023
c1e87e6
Return value
Jun 7, 2023
7ff75b8
Implement WAL tailing for hot backup
Jun 20, 2023
f651817
Hotbackup for IResearch
Jun 21, 2023
d0e74ac
IResearch HotBackup
Jun 21, 2023
3ed9aa7
Some deletes
Jun 21, 2023
c933d7c
Add copyright headers
Jun 22, 2023
6966a0c
Implement our own WAL tailer
Jun 22, 2023
a39b2b9
Clean up and simplify RocksDBWalTailer
Jun 23, 2023
b98752e
Add index pointer to rocksbackup helper
Jun 23, 2023
dc30439
Simplify HotBackup code
Jun 23, 2023
f6c21fe
Fixes to have it not crash on me
Jun 23, 2023
8409658
Move IResearchDataStoreHotbackupHelper to enterprise repo
Jun 26, 2023
27fffb7
Merge branch 'devel' into feature/block-commit-hot-backup
Jun 26, 2023
020e4ed
Require StorageEngine
Jun 26, 2023
4b40446
Document the behaviour of the WalTailer for future-me
Jun 27, 2023
66dbcc8
Yolodb
Jun 28, 2023
300d236
Update rocksdb
Jun 29, 2023
d4349c5
Remove unnecessary code
Jun 29, 2023
c2972d1
Merge branch 'devel' into feature/block-commit-hot-backup
Jun 30, 2023
e919bc7
Merge branch 'devel' into feature/block-commit-hot-backup
Jul 6, 2023
32a9538
Merge branch 'devel' into feature/block-commit-hot-backup
Jul 7, 2023
3c26f80
Move enterprise stuff to enterprise repository
Jul 7, 2023
01776bb
Merge remote-tracking branch 'origin/devel' into feature/block-commit…
Jul 10, 2023
e00ff20
Run hotbackup test in circleci
Jul 10, 2023
9791b13
Run hot backup test
Jul 10, 2023
3e49ffe
Try running HotBackupConsistencyTest in CI
Jul 10, 2023
d035f2e
Fix Hotbackup consistency test for CircleCI
Jul 10, 2023
4d3b11e
Cleanup circleci
Jul 10, 2023
0c0f42f
Move HotBackup C++ test to enterprise repo
Jul 10, 2023
4cbddb8
Shutdown cluster in order
Jul 10, 2023
6a17aa3
Remove unused code
Jul 10, 2023
20559ed
Code cleanup.
maierlars Jul 10, 2023
ec2f07a
Improvements in HotBackupConsistencyTest.py
Jul 11, 2023
8b82791
Merge branch 'feature/block-commit-hot-backup' of github.com:arangodb…
Jul 11, 2023
22662b3
Remove useless commit lock.
maierlars Jul 11, 2023
1140232
Code cleanup.
maierlars Jul 12, 2023
9a5281d
Added AQL transaction commit handling.
maierlars Jul 12, 2023
f97d8b4
Added test for AQL.
maierlars Jul 12, 2023
d6e847c
Made test silent again.
maierlars Jul 12, 2023
ab22136
Add broken smart graph test.
maierlars Jul 12, 2023
3fe5aad
Added elCheapo transaction tests.
maierlars Jul 12, 2023
dcff6ae
fix ensure_workdir
Jul 12, 2023
d0603cc
Fixing globally managed transactions.
maierlars Jul 12, 2023
c4035a5
Merge remote-tracking branch 'origin/devel' into feature/block-commit…
maierlars Jul 13, 2023
77ca2a3
Final touch for rocksdb.
maierlars Jul 13, 2023
60769d4
More renaming.
maierlars Jul 13, 2023
ea9348b
More code cleanup.
maierlars Jul 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add index pointer to rocksbackup helper
  • Loading branch information
Markus Pfeiffer committed Jun 23, 2023
commit b98752e8fa9e440816f2e54bb9c0ee7cc529518d
13 changes: 9 additions & 4 deletions arangod/IResearch/IResearchDataStoreHotbackupHelper.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@
namespace arangodb::iresearch {

struct IResearchDataStoreHotbackupHelper : public IResearchDataStore {
IResearchDataStoreHotbackupHelper(std::string path)
: IResearchDataStore(IResearchDataStore::DefaultConstructKey{}) {
IResearchDataStoreHotbackupHelper(std::string path, Index* originalIndex)
: IResearchDataStore(IResearchDataStore::DefaultConstructKey{}),
_originalIndex(originalIndex) {
_dataStore._path = path;
}
arangodb::Result initDataStore(
Expand Down Expand Up @@ -67,8 +68,10 @@ struct IResearchDataStoreHotbackupHelper : public IResearchDataStore {
*meta._indexingContext);
}

[[nodiscard]] Index& index() noexcept final { TRI_ASSERT(false); }
[[nodiscard]] Index const& index() const noexcept final { TRI_ASSERT(false); }
[[nodiscard]] Index& index() noexcept final { return *_originalIndex; }
[[nodiscard]] Index const& index() const noexcept final {
return *_originalIndex;
}
[[nodiscard]] AnalyzerPool::ptr findAnalyzer(
AnalyzerPool const& analyzer) const final {
TRI_ASSERT(false);
Expand All @@ -79,6 +82,8 @@ struct IResearchDataStoreHotbackupHelper : public IResearchDataStore {
TRI_ASSERT(false);
return {};
}

Index* _originalIndex;
};

} // namespace arangodb::iresearch