Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/distribute simplification #13509

Merged
merged 18 commits into from
Feb 9, 2021
Merged

Feature/distribute simplification #13509

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c72b0be
experimental refactoring
jsteemann Jan 28, 2021
73fa8d6
Add internal MAKE_DISTRIBUTE_INPUT functions.
mpoeter Feb 1, 2021
d5b2ac8
Merge remote-tracking branch 'origin/devel' into feature/distribute-s…
mpoeter Feb 3, 2021
b6269be
Merge remote-tracking branch 'origin/devel' into feature/distribute-s…
mpoeter Feb 4, 2021
05bf094
Simplify DistributeExecutor and instead insert MAKE_DISTRIBUTE_INPUT …
mpoeter Feb 4, 2021
bf60207
Introduce targetNodeId.
mpoeter Feb 8, 2021
6990867
Refactor and simplify.
mpoeter Feb 8, 2021
d84ecbe
Merge remote-tracking branch 'origin/devel' into feature/distribute-s…
mpoeter Feb 8, 2021
a853bf8
Add tests.
mpoeter Feb 8, 2021
506a521
Merge remote-tracking branch 'origin/devel' into feature/distribute-s…
mpoeter Feb 8, 2021
b8f918b
Update CHANGELOG.
mpoeter Feb 8, 2021
19e68ca
Fix jslint errors.
mpoeter Feb 8, 2021
26fb3cf
Merge remote-tracking branch 'origin/devel' into feature/distribute-s…
mpoeter Feb 8, 2021
504bcf4
Remove unused variable.
mpoeter Feb 9, 2021
b8092ce
Merge remote-tracking branch 'origin/devel' into feature/distribute-s…
mpoeter Feb 9, 2021
7e5eabd
Use BuilderLeaser instead of local VPackBuilder and fix remaining TODO.
mpoeter Feb 9, 2021
e535f27
Simplify explainer output and adapt tests.
mpoeter Feb 9, 2021
0858838
Update arangod/Aql/Functions.cpp
jsteemann Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.
  • Loading branch information
@mpoeter
mpoeter committed Feb 8, 2021
commit b8f918b2ecedc1b226f02f8716fd6b0d32de8f52
9 changes: 9 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
devel
-----

* Simplify the DistributeExecutor and avoid implicit modification of its input
variable. Previously the DistributeExecutor could update the input variable
in-place, leading to unexpected results (see #13509).
The modification logic has now been moved into three new _internal_ AQL
functions (MAKE_DISTRIBUTE_INPUT, MAKE_DISTRIBUTE_INPUT_WITH_KEY_CREATION,
and MAKE_DISTRIBUTE_GRAPH_INPUT) and an additional calculation node with an
according function call will be introduced if we need to prepare the input
data for the distribute node.

* More improvements for logging:

* Added new REST API endpoint GET `/_admin/log/entries` to return log entries
Expand Down