Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add analytics events DAO-97 #1567

Merged
merged 7 commits into from
Jul 29, 2021
Merged

add analytics events DAO-97 #1567

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc212d3
implement analytics events
Rekard0 Jul 27, 2021
d1093e2
clean up
Rekard0 Jul 27, 2021
3c7907a
add dao address to created event
Rekard0 Jul 28, 2021
062096c
clean up
Rekard0 Jul 28, 2021
51e7a8e
only emit event if creating a DAO
Rekard0 Jul 28, 2021
ea8c40c
pass address or ens
Rekard0 Jul 29, 2021
bdbcaa1
bug fixing
Rekard0 Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pass address or ens
  • Loading branch information
@Rekard0
Rekard0 committed Jul 29, 2021
commit ea8c40c64993b7a03cf90807068f61c504354d8f
7 changes: 2 additions & 5 deletions src/onboarding/Create/Create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
TRANSACTION_STATUS_UPCOMING,
} from '../../symbols'
import { log } from '../../utils'
import { getGasPrice, isValidEnsName } from '../../web3-utils'
import { getGasPrice } from '../../web3-utils'
import {
loadTemplateState,
saveTemplateState,
Expand Down Expand Up @@ -287,10 +287,7 @@ function useDeploymentState(
transaction?.data === deployTransactions[0]?.transaction?.data
) {
const daoEns = `${templateData.domain}.aragonid.eth`
const isDomain = isValidEnsName(daoEns)
const daoAddress = isDomain
? await resolveEnsDomain(daoEns)
: daoEns
const daoAddress = (await resolveEnsDomain(daoEns)) || daoEns

trackEvent(events.DAO_CREATED, {
network: networkName,
Expand Down