Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): error on missing config file #7154

Merged
merged 5 commits into from
Jul 25, 2024
Merged

fix(cli): error on missing config file #7154

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e25efc
fix: error out when explicitly config file cannot be found
sgaist Jul 12, 2024
cfebe6a
refactor: log a warning when default configuration is not found
sgaist Jul 16, 2024
3d397f0
refactor: put log back to debug when default configuration is not found
sgaist Jul 17, 2024
300d2d8
fix(app_test): simplify string to check for missing configuration error
sgaist Jul 18, 2024
aed9b7b
Merge branch 'main' into error_on_missing_config_file
sgaist Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(app_test): simplify string to check for missing configuration error 
Part of the message is OS dependent so remove it to ensure it passes
on all platforms.
  • Loading branch information
@sgaist
sgaist committed Jul 18, 2024
commit 300d2d8d621a73af9cc175cb47789925d3727656
2 changes: 1 addition & 1 deletion pkg/commands/app_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ func TestFlags(t *testing.T) {
"--config",
"none",
},
wantErr: `config file "none" loading error: open none: no such file or directory`,
wantErr: `config file "none" loading error: open none:`,
},
}

Expand Down
Loading