Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky TestDockerEngine #6054

Merged
merged 2 commits into from
Feb 2, 2024
Merged

test: fix flaky TestDockerEngine #6054

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fb678a
test: close ImageLoad response, don't check for error when Cleanup
DmitriyLewen Feb 2, 2024
f41be40
test: fix mistakes
DmitriyLewen Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix mistakes
  • Loading branch information
@DmitriyLewen
DmitriyLewen committed Feb 2, 2024
commit f41be4090b4152b5dac6a48da267f5af9400c6de
6 changes: 3 additions & 3 deletions integration/docker_engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,10 @@ func TestDockerEngine(t *testing.T) {
// load image into docker engine
res, err := cli.ImageLoad(ctx, testfile, true)
require.NoError(t, err, tt.name)
if _, err := io.Copy(io.Discard, resp.Body); err != nil {
return err
if _, err := io.Copy(io.Discard, res.Body); err != nil {
require.NoError(t, err, tt.name)
}
defer resp.Body.Close()
defer res.Body.Close()

// tag our image to something unique
err = cli.ImageTag(ctx, tt.imageTag, tt.input)
Expand Down
Loading