Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use the formula maintained by Homebrew #3389

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Jan 5, 2023

Description

Homebrew currently maintains the Trivy formula. It is better to use it rather than our formula.
https://github.com/Porkepix/homebrew-core/blob/master/Formula/trivy.rb

Homebrew didn't use to have trivy and we needed to maintain our tap. We no longer have to maintain that, but keep it for compatibility.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 requested a review from AnaisUrlichs as a code owner January 5, 2023 10:47
@knqyf263 knqyf263 self-assigned this Jan 5, 2023
@knqyf263 knqyf263 requested a review from itaysk as a code owner January 5, 2023 10:47
@itaysk
Copy link
Contributor

itaysk commented Jan 5, 2023

This change, as well as other installation related improvements are included in #3368

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Jan 5, 2023

Yes, but #3368 may take some more time. I think Anais will also review that, right? I want to fix this right now so it will not confuse users.

@knqyf263 knqyf263 merged commit ad2e648 into aquasecurity:main Jan 5, 2023
@knqyf263 knqyf263 deleted the docs/homebrew_official branch January 5, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants