-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding test for git import export for gitconnected app #37604
Conversation
WalkthroughThis pull request introduces a new Cypress end-to-end test suite for the partial import and export functionality in a Git-connected application. The suite includes four test cases that validate various scenarios, such as exporting and importing elements, re-importing to the same page, importing into a new application, and importing to a Git branch. The tests are structured to ensure comprehensive coverage of the import/export processes and utilize helper functions for managing application state. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PartialImportWithGitConnectedApp_spec.ts (2)
33-33
: Remove empty beforeEach block.Empty beforeEach blocks should be removed to maintain clean test code.
- beforeEach(() => {});
35-188
: Consider extracting common import/export steps into helper functions.The test cases contain repeated patterns for importing widgets and queries. Consider creating helper functions to reduce code duplication:
const importWidgetsAndQueries = (widgetFile: string, queryFile: string) => { // Import Widgets partialImportExport.OpenImportModal(); partialImportExport.ImportPartiallyExportedFile( widgetFile, "Widgets", ["Table1", "Button1"], ); // Import Queries partialImportExport.OpenImportModal(); partialImportExport.ImportPartiallyExportedFile( queryFile, "Queries", ["Api1"], ); };
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PartialImportWithGitConnectedApp_spec.ts
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PartialImportWithGitConnectedApp_spec.ts (1)
Pattern app/client/cypress/**/**.*
: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🔇 Additional comments (2)
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PartialImportWithGitConnectedApp_spec.ts (2)
1-15
: LGTM! Well-organized imports and setup.
The imports are properly structured using ObjectsCore, and constants are appropriately defined.
137-138
: Verify the purpose of consecutive CreateGitBranch calls.
Two consecutive CreateGitBranch calls seem suspicious. The second call has no branch name parameter.
partialImportExport.OpenImportModal(); | ||
partialImportExport.ImportPartiallyExportedFile( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Refactor duplicate OpenImportModal calls.
Multiple consecutive calls to OpenImportModal are redundant and should be removed.
- partialImportExport.OpenImportModal();
partialImportExport.ImportPartiallyExportedFile(
Also applies to: 68-69, 143-144, 151-152, 168-169, 176-177
fixtureName, | ||
); | ||
|
||
cy.wait(5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace cy.wait with proper assertions.
Using cy.wait is against the coding guidelines. Instead, wait for specific elements or network requests to complete.
- cy.wait(5000);
+ // Wait for specific condition instead, e.g.:
+ agHelper.AssertElementVisibility(locators._newPage);
Committable suggestion skipped: line range outside the PR's diff.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
This PR has been closed because of inactivity. |
Added test for git import and export for a git connected app
Summary by CodeRabbit
New Features
Tests