Fix paths with spaces in $APPLE_PLUGIN_LIBRARY_ROOT for Apple.Core #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just seen that this is fixed in another PR (#31), although the other solution is not POSIX compliant, and doesn't follow the same quoting format used in the rest of the script. |
|
In case anybody else comes across this issue (
|
Andrew-Grabish-HypGames
pushed a commit
to HypGamesOrlando/unityplugins
that referenced
this pull request
Sep 17, 2024
… info.plist for each library is causing App Store rejections (apple#38) * Updated each native library project to define the CFBundleShortVersionString in an xcconfig file along with a few other related settings. * Needed to clean up the override in the build settings for CoreHaptics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build our Unity project in a particular path that had spaces in it, we encountered this error:
This prevented us from building and Googling this issue yielded no fixes. In the end, it turns out that the build script for the Embed Apple Plug-in Libraries Build Phase does not enclose the
$APPLE_PLUGIN_LIBRARY_ROOTvariable with double quotes in the first conditional that checks for the existence of the library directory. This results in paths with spaces becoming multiple arguments for the[command of theifline, which crashes the build process:I've thus enclosed the variable with double quotes so this script works with paths that have spaces in them.