Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: repair the ability to build with build tree artifacts #117

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Contributor

This restores the ability to build swift-collections with build tree
artifacts for the toolchain. The newly introduced dependency on
Foundation in PriorityQueueModule requires linking against Foundation
and dispatch in the case that the system does not provide the libraries
and you do not have a complete toolchain on hand.

Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

This restores the ability to build swift-collections with build tree
artifacts for the toolchain.  The newly introduced dependency on
Foundation in PriorityQueueModule requires linking against Foundation
and dispatch in the case that the system does not provide the libraries
and you do not have a complete toolchain on hand.
@compnerd compnerd requested a review from lorentey as a code owner October 11, 2021 18:37
@compnerd
Copy link
Contributor Author

@swift-ci please test

@lorentey
Copy link
Member

The newly introduced dependency on
Foundation in PriorityQueueModule

This was a mistake, presumably triggered by Xcode's insistence on adding an import Foundation statement to new Swift files. The correct fix would be to remove the dependency!

@compnerd
Copy link
Contributor Author

Sure, removal is fine in my book as well. Let me see if I can whip up a patch for that.

@compnerd
Copy link
Contributor Author

Trying locally and on CI with #118

@compnerd compnerd closed this Oct 11, 2021
@compnerd compnerd deleted the build-tree branch October 11, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants