-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-3016] Cleanup cluster resources after persistent_volume e2e test failed #947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for you patch! Having a simple question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your prompt reply.
Overall LGTM to me, only a small thing left.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
==========================================
+ Coverage 67.99% 68.04% +0.05%
==========================================
Files 70 70
Lines 9195 9195
==========================================
+ Hits 6252 6257 +5
+ Misses 2735 2731 -4
+ Partials 208 207 -1 ☔ View full report in Codecov by Sentry. |
+1 LGTM |
What is this PR for?
In the e2e test persistent_volume_test.go, the test case Verify_dynamic_binding_with_nfs_server may leave behind cluster resources (e.g., StorageClasses, ClusterRoles, Deployments, etc.) when the test fails. These resources could cause subsequent tests using the same namespace to encounter unexpected errors.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3016
How should this be tested?
Screenshots (if appropriate)
Questions: