Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[db migration] change datasources-clusters foreign key to cluster_id #8576

Merged
merged 3 commits into from
Jan 13, 2020
Merged

[db migration] change datasources-clusters foreign key to cluster_id #8576

merged 3 commits into from
Jan 13, 2020

Conversation

serenajiang
Copy link
Contributor

@serenajiang serenajiang commented Nov 15, 2019 •
edited
Loading

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation
  • Schema change

SUMMARY

Change the foreign key for datasources->clusters from cluster_name to cluster_id (the primary key of clusters).

TEST PLAN

tox passes.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@john-bodley @mistercrunch

@serenajiang serenajiang force-pushed the serena-datasources-clusters-foreign-key branch from bfbe80a to cc7e03d Compare January 8, 2020 21:44
@serenajiang serenajiang force-pushed the serena-datasources-clusters-foreign-key branch from cc7e03d to e829afd Compare January 8, 2020 21:59
@serenajiang serenajiang marked this pull request as ready for review January 8, 2020 22:06
@serenajiang serenajiang changed the title [wip][db migration] change datasources-clusters foreign key to cluster_id [db migration] change datasources-clusters foreign key to cluster_id Jan 8, 2020
john-bodley
john-bodley reviewed Jan 8, 2020
View reviewed changes
superset/connectors/druid/models.py Outdated Show resolved Hide resolved
superset/connectors/druid/models.py Outdated Show resolved Hide resolved
superset/connectors/druid/views.py Show resolved Hide resolved
superset/migrations/versions/e96dbf2cfef0_datasource_cluster_fk.py Show resolved Hide resolved
superset/migrations/versions/e96dbf2cfef0_datasource_cluster_fk.py Outdated Show resolved Hide resolved
superset/utils/core.py Show resolved Hide resolved
superset/utils/core.py Show resolved Hide resolved
tests/dict_import_export_tests.py Outdated Show resolved Hide resolved
@john-bodley john-bodley merged commit 1f6f4ed into apache:master Jan 13, 2020
@serenajiang serenajiang mentioned this pull request Jan 22, 2020
Merged
12 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serenajiang @john-bodley @mistercrunch