Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using indexOf instead of includes for isXAxisString #3733

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Using indexOf instead of includes for isXAxisString #3733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Using indexOf instead of includes for isXAxisString
  • Loading branch information
@michellethomas
michellethomas committed Oct 27, 2017
commit 913f5c30abe57fdda50949f3903de19376cdba0f
2 changes: 1 addition & 1 deletion superset/assets/visualizations/nvd3_vis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ function nvd3Vis(slice, payload) {
chart.x2Axis.tickFormat(xAxisFormatter);
height += 30;
}
const isXAxisString = ['dist_bar', 'box_plot'].includes(vizType) >= 0;
const isXAxisString = ['dist_bar', 'box_plot'].indexOf(vizType) >= 0;
if (!isXAxisString && chart.xAxis && chart.xAxis.tickFormat) {
chart.xAxis.tickFormat(xAxisFormatter);
}
Expand Down