Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use RLS clause instead of ID for cache key #25229

Merged
merged 13 commits into from
Sep 18, 2023
Merged

fix: Use RLS clause instead of ID for cache key #25229

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3f60aff
Use RLS clause instead of ID for cache key
jfrag1 Sep 8, 2023
885b28a
Fix type hint
jfrag1 Sep 8, 2023
7f92e65
Fix typo
jfrag1 Sep 8, 2023
b3e265e
Address comments
jfrag1 Sep 15, 2023
e1e43ae
Rename var
jfrag1 Sep 15, 2023
6b9e7b6
Formatting
jfrag1 Sep 15, 2023
464f257
Don't concat id
jfrag1 Sep 15, 2023
266467c
Concat group key
jfrag1 Sep 15, 2023
b454725
Add dash
jfrag1 Sep 15, 2023
f176b56
pylint ignore
jfrag1 Sep 16, 2023
a651f53
Change structure to allow for more re-usability
jfrag1 Sep 18, 2023
e41167d
Formatting
jfrag1 Sep 18, 2023
1db0ae6
Oops
jfrag1 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Oops
  • Loading branch information
@jfrag1
jfrag1 committed Sep 18, 2023
commit 1db0ae68033090feea390effaa656003d93cabed
2 changes: 1 addition & 1 deletion superset/security/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2099,7 +2099,7 @@ def get_guest_rls_filters_str(self, table: "BaseDatasource") -> list[str]:
return [f.get("clause", "") for f in self.get_guest_rls_filters(table)]

def get_rls_cache_key(self, datasource: "BaseDatasource") -> list[str]:
rls_clauses = []
rls_clauses_with_group_key = []
if datasource.is_rls_supported:
rls_clauses_with_group_key = [
f"{f.clause}-{f.group_key or ''}"
Expand Down