Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): restrict list view and gamma perms #21765

Merged
merged 9 commits into from
Oct 15, 2022
Merged

fix(alerts): restrict list view and gamma perms #21765

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e6b6799
fix: remove alerts and reports perms for gamma
villebro Oct 10, 2022
9d928a8
add base filter for report schedule
villebro Oct 11, 2022
8678320
fix old tests
villebro Oct 11, 2022
ca2939f
add tests
villebro Oct 11, 2022
fbd2e2d
check g.user
villebro Oct 12, 2022
24409b0
address comment on UPDATING.md
villebro Oct 13, 2022
4bdcfee
make all alerts visible to alpha and add gamma tests
villebro Oct 13, 2022
cb951b1
disable forbidden actions
villebro Oct 14, 2022
c2761a3
fix test
villebro Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
@villebro
villebro committed Oct 14, 2022
commit c2761a311a4af17f79ed1b6a1b26324e8b490cb2
4 changes: 3 additions & 1 deletion superset-frontend/src/views/CRUD/alert/AlertList.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const mockalerts = [...new Array(3)].map((_, i) => ({
last_eval_dttm: Date.now(),
last_state: 'ok',
name: `alert ${i} `,
owners: [],
owners: [{ id: 1 }],
recipients: [
{
id: `${i}`,
Expand All @@ -67,6 +67,8 @@ const mockalerts = [...new Array(3)].map((_, i) => ({

const mockUser = {
userId: 1,
firstName: 'user 1',
lastName: 'lastname',
};

fetchMock.get(alertsEndpoint, {
Expand Down