Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): restrict list view and gamma perms #21765

Merged
merged 9 commits into from
Oct 15, 2022
+221 −41
Merged

fix(alerts): restrict list view and gamma perms #21765

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e6b6799
fix: remove alerts and reports perms for gamma
villebro Oct 10, 2022
9d928a8
add base filter for report schedule
villebro Oct 11, 2022
8678320
fix old tests
villebro Oct 11, 2022
ca2939f
add tests
villebro Oct 11, 2022
fbd2e2d
check g.user
villebro Oct 12, 2022
24409b0
address comment on UPDATING.md
villebro Oct 13, 2022
4bdcfee
make all alerts visible to alpha and add gamma tests
villebro Oct 13, 2022
cb951b1
disable forbidden actions
villebro Oct 14, 2022
c2761a3
fix test
villebro Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comment on UPDATING.md
  • Loading branch information
@villebro
villebro committed Oct 14, 2022
commit 24409b09092db17cbd629498af54e796e33b699f
2 changes: 1 addition & 1 deletion UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ assists people when migrating to a new version.

### Breaking Changes

- [21765](https://github.com/apache/superset/pull/21765): Gamma users will no longer have read and write access to Alerts & Reports. To give Gamma users the ability to schedule alerts and reports like before, create an additional role with "can read on ReportSchedule", "can write on ReportSchedule", "menu access on Manage" and "menu access on Alerts & Report".
- [21765](https://github.com/apache/superset/pull/21765): For deployments that have enabled the "ALERT_REPORTS" feature flag, Gamma users will no longer have read and write access to Alerts & Reports by default. To give Gamma users the ability to schedule reports from the Dashboard and Explore view like before, create an additional role with "can read on ReportSchedule" and "can write on ReportSchedule" permissions. To further give Gamma users access to the "Alerts & Reports" menu and CRUD view, add "menu access on Manage" and "menu access on Alerts & Report" permissions to the role.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@villebro I wonder if someone were to read this entry without seeing your explanation in the PR, if they would think that they need to grant access to Gamma users to keep the same functionality that we have now. This is tricky, because to most people it won't look like a breaking change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I'll make the entry more explicit, specifically scoping this to deployments that have enabled the "ALERT_REPORTS" feature flag.

### Potential Downtime

Expand Down