Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Make FilterBar width resizable #20778

Merged
merged 9 commits into from
Jul 20, 2022
Merged

feat(dashboard): Make FilterBar width resizable #20778

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a6409d4
feat(dashboard): Resizable side FilterBar
justinpark Jul 19, 2022
bf1d068
replace to testing-library/react
justinpark Jul 19, 2022
43d77a8
test lint
justinpark Jul 19, 2022
843c463
replace toHaveLength() by length and toBe
justinpark Jul 19, 2022
3ca5ca2
prettier
justinpark Jul 19, 2022
66f705e
use defaultValue for width
justinpark Jul 19, 2022
985e748
unexpected string concat
justinpark Jul 19, 2022
c6ce937
use find for header delay rendering
justinpark Jul 19, 2022
0c55015
missing test-id for dashboard-header
justinpark Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use defaultValue for width
  • Loading branch information
@justinpark
justinpark committed Jul 20, 2022
commit 66f705ea7f0db38766d7771007167e1d6fda7b92
7 changes: 2 additions & 5 deletions superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const ActionButtonsContainer = styled.div<{ width: number }>`
`;

export const ActionButtons = ({
width,
width = OPEN_FILTER_BAR_WIDTH,
onApply,
onClearAll,
dataMaskApplied,
Expand All @@ -105,10 +105,7 @@ export const ActionButtons = ({
);

return (
<ActionButtonsContainer
data-test="filterbar-action-buttons"
width={width || OPEN_FILTER_BAR_WIDTH}
>
<ActionButtonsContainer data-test="filterbar-action-buttons" width={width}>
<Button
disabled={isApplyDisabled}
buttonStyle="primary"
Expand Down