Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement contributing.md #10859

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Improvement contributing.md #10859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ea3e3
Improvement contributing.md
zhaoyongjie Sep 14, 2020
0db3f5b
update
zhaoyongjie Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,17 +392,11 @@ python setup.py build_sphinx

Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps.

Developers should use a virtualenv.

```bash
pip install virtualenv
```

Then proceed with:
Ensure Python versions >3.7, Then proceed with:

```bash
# Create a virtual environemnt and activate it (recommended)
virtualenv -p python3 venv # setup a python3.6 virtualenv
python3 -m venv venv # setup a python3 virtualenv
source venv/bin/activate

# Install external dependencies
Expand Down Expand Up @@ -715,7 +709,7 @@ Superset includes a [Storybook](https://storybook.js.org/) to preview the layout

```bash
cd superset-frontend
npm run storybool
npm run storybook
```

When contributing new React components to Superset, please try to add a Story alongside the component's `jsx/tsx` file.
Expand Down