STORM-4154 - fix: Nimbus downtime during topology deployment #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paxadax
approved these changes
Jan 13, 2025
reiabreu
approved these changes
Jan 13, 2025
|
Thanks for the PR @DiogoP98 ! |
vitormelo-fd
approved these changes
Jan 13, 2025
DiogoP98
force-pushed
the
STORM-4154-nimbus-downtime-during-topology-deployment
branch
from
977fd65 to
bdc3a13
Compare
miguel-silva-fd
approved these changes
Jan 14, 2025
rzo1
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When deploying or killing a topology in a distributed cluster, we occasionally encounter downtime on the Nimbus machines.
This issue occurs due to a race condition when syncing the blobs. On some machines, the key we are trying to fetch information for during the process of creating the state in ZooKeeper for a recently downloaded blob might disappear. This results in a Thrift exception that is not being handled properly, causing the Nimbus process to crash.
This PR addresses that issue, by handling the
KeyNotFoundExceptionerror when creating the state in zookeeper.Issue: https://issues.apache.org/jira/browse/STORM-4154
How was the change tested
Compiled the project, and tested the new version of the code in Nimbus machines, forcing Nimbus to download a non-existent key.