[SPARK-50665][SQL] Substitute LocalRelation with ComparableLocalRelation in NormalizePlan #49287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Dec 25, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/NormalizePlan.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Dec 25, 2024
vladimirg-db
force-pushed
the
vladimirg-db/normalize-local-relation
branch
from
1d35601 to
be2287d
Compare
vladimirg-db
force-pushed
the
vladimirg-db/normalize-local-relation
branch
from
be2287d to
da832da
Compare
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Substitute
LocalRelationwithComparableLocalRelationinNormalizePlan.ComparableLocalRelationhasSeq[Seq[Expression]]instead ofSeq[InternalRow]. The conversion happens throughLiterals.Why are the changes needed?
LocalRelation's data field is incomparable if it contains maps, becauseArrayBasedMapDatadoesn't defineequals: #13847Does this PR introduce any user-facing change?
No. This is to compare logical plans in the single-pass Analyzer.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
copilot.nvim.