Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace akka based names in logging code #197

Merged
merged 6 commits into from
Feb 16, 2023
Merged

replace akka based names in logging code #197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d241ed2
replace akka based names in logging code
pjfanning Feb 15, 2023
8b5e97b
try to fix tests
pjfanning Feb 15, 2023
71dc8d3
fix test code
pjfanning Feb 15, 2023
7007089
Update ActorLoggingSpec.scala
pjfanning Feb 15, 2023
b709a29
try to fix test
pjfanning Feb 15, 2023
a2445de
Revert "try to fix test"
pjfanning Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try to fix test
  • Loading branch information
@pjfanning
pjfanning committed Feb 15, 2023
commit b709a291d25293145b9380b081757e43607150ed
2 changes: 1 addition & 1 deletion actor-tests/src/test/scala/org/apache/pekko/serialization/SerializeSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ class SerializeSpec extends PekkoSpec(SerializationTests.serializeConf) {
}

"log warning if non-Pekko serializer is configured for Pekko message" in {
EventFilter.warning(pattern = ".*not implemented by Pekko.*", occurrences = 1).intercept {
EventFilter.warning(pattern = ".*not implemented by Apache Pekko.*", occurrences = 1).intercept {
ser.serialize(new Other).get
}
}
Expand Down
4 changes: 2 additions & 2 deletions actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,8 @@ class Serialization(val system: ExtendedActorSystem) extends Extension {
if (clazz.getName.startsWith("org.apache.pekko.") && !ser.getClass.getName.startsWith("org.apache.pekko.")) {
log.warning(
"Using serializer [{}] for message [{}]. Note that this serializer " +
"is not implemented by Pekko. It's not recommended to replace serializers for messages " +
"provided by Pekko.",
"is not implemented by Apache Pekko. It's not recommended to replace serializers for messages " +
"provided by Apache Pekko.",
ser.getClass.getName,
clazz.getName)
true
Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/paradox/typed/logging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ via the SLF4J backend, such as Logback configuration.

## Introduction

[SLF4J](https://www.slf4j.org/) is used for logging and Pekko provides access to an [org.slf4j.Logger](https://www.slf4j.org/api/org/slf4j/Logger.html) for a specific
[SLF4J](https://www.slf4j.org/) is used for logging and Apache Pekko provides access to an [org.slf4j.Logger](https://www.slf4j.org/api/org/slf4j/Logger.html) for a specific
actor via the @apidoc[typed.*.ActorContext]. You may also retrieve a `Logger` with the ordinary [org.slf4j.LoggerFactory](https://www.slf4j.org/api/org/slf4j/LoggerFactory.html).

To ensure that logging has minimal performance impact it's important that you configure an
Expand Down