Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add couchdb conf dir #5285

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add couchdb conf dir #5285

wants to merge 7 commits into from

Conversation

style95
Copy link
Member

@style95 style95 commented Jul 15, 2022

Description

This is to persist configurations for CouchDB.
The configuration directory is configurable.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

style95
style95 commented Jul 15, 2022
View reviewed changes
ansible/roles/couchdb/files/default.d/10-docker-default.ini
@@ -0,0 +1,11 @@
; CouchDB Configuration Settings
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These default files are from the apache/couchdb:2.3 image.

ansible/roles/couchdb/files/vm.args
# All nodes must share the same magic cookie for distributed Erlang to work.
# # Comment out this line if you synchronized the cookies by other means (using
# # the ~/.erlang.cookie file, for example).
-setcookie openwhisk
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The erlang cookie is configurable with this.

@style95
Copy link
Member Author

style95 commented Jul 15, 2022

I am testing the various clustering scenario with this version.

@style95
Copy link
Member Author

style95 commented Jul 15, 2022

I have tested the followings.

  1. Deploy a CouchDB cluster with 3 nodes.
  2. Restart one of the nodes.
  3. Stop all nodes and start them again.
  4. Deploy a new cluster with 2 nodes and add another node by running the ansible script again with --limit db[2:2] option.

In all cases, a cluster was made, the cluster was stable after the restart, and a new node successfully joined the existing cluster.

@codecov-commenter
Copy link

Codecov Report

Merging #5285 (e32be04) into master (1fbfd6b) will decrease coverage by 75.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #5285       +/-   ##
==========================================
- Coverage   79.81%   4.57%   -75.24%     
==========================================
  Files         238     238               
  Lines       14154   14154               
  Branches      607     607               
==========================================
- Hits        11297     648    -10649     
- Misses       2857   13506    +10649
Impacted Files Coverage Δ
.../main/scala/org/apache/openwhisk/core/WarmUp.scala 0.00% <0.00%> (-100.00%) ⬇️
...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala 0.00% <0.00%> (-100.00%) ⬇️
...n/scala/org/apache/openwhisk/utils/JsHelpers.scala 0.00% <0.00%> (-100.00%) ⬇️
...scala/org/apache/openwhisk/common/Prometheus.scala 0.00% <0.00%> (-100.00%) ⬇️
...scala/org/apache/openwhisk/core/FeatureFlags.scala 0.00% <0.00%> (-100.00%) ⬇️
...ala/org/apache/openwhisk/common/ConfigMXBean.scala 0.00% <0.00%> (-100.00%) ⬇️
...la/org/apache/openwhisk/http/BasicRasService.scala 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/openwhisk/common/ConfigMapValue.scala 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/openwhisk/core/entity/WhiskAuth.scala 0.00% <0.00%> (-100.00%) ⬇️
.../org/apache/openwhisk/core/entity/EntityPath.scala 0.00% <0.00%> (-100.00%) ⬇️
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbfd6b...e32be04. Read the comment docs.

@style95
Copy link
Member Author

style95 commented Jul 19, 2022

The CouchDB node keeps restarting in Travis.
It complains about the permission of configuration files.
Have no idea how to solve this so far.

@style95 style95 force-pushed the add-couchdb-conf-dir branch from 094ad5c to 619ece8 Compare January 25, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdoyle0182 bdoyle0182 Awaiting requested review from bdoyle0182

@jiangpengcheng jiangpengcheng Awaiting requested review from jiangpengcheng

@KeonHee KeonHee Awaiting requested review from KeonHee

@ningyougang ningyougang Awaiting requested review from ningyougang

@upgle upgle Awaiting requested review from upgle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@style95 @codecov-commenter