Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Session windows should accept zero as session gap #18734

Merged
merged 2 commits into from
Feb 4, 2025
Merged

MINOR: Session windows should accept zero as session gap #18734

merged 2 commits into from
Feb 4, 2025
+46 −10

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Jan 29, 2025

No description provided.

@mjsax mjsax added the streams label Jan 29, 2025
@mjsax mjsax requested a review from ableegoldman January 29, 2025 01:48
@github-actions github-actions bot added the small Small PRs label Jan 29, 2025
agavra
agavra approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we shouldn't support this! I feel like this would make a good "time-based" deduplicator or something like that.

@mjsax
Copy link
Member Author

mjsax commented Jan 30, 2025

Java 17 passed.

Java 23:

Found 1 test failures:
FAILED ❌ KafkaAdminClientTest > testAdminClientApisAuthenticationFailure()
Found 2 flaky test failures:
FLAKY ⚠️  KafkaShareConsumerTest > testVerifyFetchAndAcknowledgeSync()
FLAKY ⚠️  EagerConsumerCoordinatorTest > testOutdatedCoordinatorAssignment()

@mjsax
Copy link
Member Author

mjsax commented Jan 30, 2025 •
edited
Loading

Fix for KakfaAdminClientTest is already on the way: #18735

ableegoldman
ableegoldman approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me modulo the javadocs.

Actually do we have any docs or examples anywhere that would need to be updated...?

streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java
if (gapMs <= 0) {
throw new IllegalArgumentException("Gap time cannot be zero or negative.");
if (gapMs < 0) {
throw new IllegalArgumentException("Gap time cannot be negative.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should update the javadocs for the public APIs to define the inactivity gap semantics/boundaries

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaDocs. Good catch!

Did briefly look into docs. Did not found anything that we would need to update.

@mjsax mjsax merged commit b8cafbf into apache:trunk Feb 4, 2025
8 of 9 checks passed
@mjsax mjsax deleted the minor-session-gap-zero branch February 4, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

@ableegoldman ableegoldman ableegoldman approved these changes

Assignees
No one assigned
Labels
small Small PRs streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjsax @agavra @ableegoldman