Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #2855] eventmesh-sdk-go test error #2857

Merged
merged 1 commit into from
Jan 8, 2023
Merged

[ISSUE #2855] eventmesh-sdk-go test error #2857

merged 1 commit into from
Jan 8, 2023

Conversation

jonyangx
Copy link
Contributor

@jonyangx jonyangx commented Jan 8, 2023 •
edited by xwm1992
Loading

Fixes #2855 .

Motivation

fix eventmesh-sdk-go test error

Modifications

use ginkgo test framework refactor test code.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@jonyangx jonyangx requested a review from walleliu1016 January 8, 2023 08:09
@jonyangx jonyangx self-assigned this Jan 8, 2023
@codecov
Copy link

codecov bot commented Jan 8, 2023 •
edited
Loading

Codecov Report

Merging #2857 (f2d697c) into master (34d2e6d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2857   +/-   ##
=========================================
  Coverage     11.61%   11.61%           
  Complexity      911      911           
=========================================
  Files           503      503           
  Lines         28091    28094    +3     
  Branches       2873     2876    +3     
=========================================
+ Hits           3262     3264    +2     
- Misses        24533    24534    +1     
  Partials        296      296
Impacted Files Coverage Δ
...otocol/meshmessage/MeshMessageProtocolAdaptor.java 3.77% <0.00%> (-0.08%) ⬇️
...sh/client/http/producer/EventMeshHttpProducer.java 0.00% <0.00%> (ø)
...untime/core/protocol/http/push/HTTPClientPool.java 0.00% <0.00%> (ø)
.../trace/pinpoint/exporter/PinpointSpanExporter.java 68.91% <0.00%> (+0.67%) ⬆️
.../admin/handler/QueryRecommendEventMeshHandler.java 37.03% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

walleliu1016
walleliu1016 approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@walleliu1016 walleliu1016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walleliu1016 walleliu1016 merged commit 23855e6 into apache:master Jan 8, 2023
@jonyangx jonyangx deleted the issue2855 branch January 9, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walleliu1016 walleliu1016 walleliu1016 approved these changes

Assignees

@jonyangx jonyangx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] eventmesh-sdk-go test error
2 participants
@jonyangx @walleliu1016