Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #1818] Fix IOException in SSLContextFactory #1819

Merged
merged 4 commits into from
Oct 25, 2022
Merged

[ISSUE #1818] Fix IOException in SSLContextFactory #1819

merged 4 commits into from
Oct 25, 2022

Conversation

krittysv
Copy link
Contributor

Fixes #1818 .

Motivation

Handled IOException in eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/SSLContextFactory.java

Modifications

Enclose inputStream.close() in try-catch block and caught IOException.

Documentation

  • Does this pull request introduce a new feature? (yes / no) No
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) Not applicable
  • If a feature is not applicable for documentation, explain why? Minor issue which comes under code cleanup.

qqeasonchen
qqeasonchen approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@qqeasonchen qqeasonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqeasonchen qqeasonchen merged commit 7c3365f into apache:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqeasonchen qqeasonchen qqeasonchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix IOException in SSLContextFactory
2 participants
@krittysv @qqeasonchen