Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #1213] Knative Connector: Documentation for Producer/Consumer (Publish/Subscribe). #1225

Merged
merged 3 commits into from
Sep 6, 2022
Merged

[ISSUE #1213] Knative Connector: Documentation for Producer/Consumer (Publish/Subscribe). #1225

merged 3 commits into from
Sep 6, 2022

Conversation

pchengma
Copy link
Member

@pchengma pchengma commented Sep 5, 2022 •
edited
Loading

Fixed ISSUE #1213.

Motivation

Uploaded documentation for Knative Connector producer/consumer implementation.
This PR follows issue #790 and pull request #1214.

Modifications

  • Added English and Chinese documentation for publish/subscribe methods of producer/consumer with demo.
  • Added missing license and configurations for Knative Connector.

Documentation

  • Does this pull request introduce a new feature? No.
  • If yes, how is the feature documented? N/A.
  • If a feature is not applicable for documentation, explain why? This PR is for documentation.
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation. N/A.

@codecov
Copy link

codecov bot commented Sep 5, 2022 •
edited
Loading

Codecov Report

Merging #1225 (56051ec) into master (7baeb18) will increase coverage by 0.27%.
The diff coverage is n/a.

❗ Current head 56051ec differs from pull request most recent head 863cf56. Consider uploading reports for the commit 863cf56 to get more accurate results

@@             Coverage Diff              @@
##             master    #1225      +/-   ##
============================================
+ Coverage     10.92%   11.19%   +0.27%     
- Complexity      730      760      +30     
============================================
  Files           403      421      +18     
  Lines         24346    24592     +246     
  Branches       2680     2685       +5     
============================================
+ Hits           2659     2754      +95     
- Misses        21430    21577     +147     
- Partials        257      261       +4
Impacted Files Coverage Δ
...ava/org/apache/eventmesh/common/utils/IPUtils.java 34.25% <0.00%> (-5.56%) ⬇️
...g/apache/eventmesh/runtime/util/EventMeshUtil.java 75.73% <0.00%> (-5.15%) ⬇️
...ctor/knative/cloudevent/KnativeMessageFactory.java 100.00% <0.00%> (ø)
...connector/knative/config/ConfigurationWrapper.java 52.63% <0.00%> (ø)
...connector/ConnectorResourceServiceKnativeImpl.java 0.00% <0.00%> (ø)
...ve/cloudevent/impl/KnativeBinaryMessageReader.java 0.00% <0.00%> (ø)
...sh/connector/knative/consumer/DefaultConsumer.java 62.50% <0.00%> (ø)
...onnector/knative/consumer/KnativeConsumerImpl.java 37.50% <0.00%> (ø)
.../knative/cloudevent/impl/KnativeMessageWriter.java 66.66% <0.00%> (ø)
...tive/patch/EventMeshConsumeConcurrentlyStatus.java 0.00% <0.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qqeasonchen qqeasonchen merged commit b7a395b into apache:master Sep 6, 2022
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this pull request Sep 23, 2022
@qqeasonchen
Merge pull request apache#1225 from pchengma/master
d656daa 
[ISSUE apache#1213] Knative Connector: Documentation for Producer/Consumer (Publish/Subscribe).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqeasonchen qqeasonchen qqeasonchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchengma @qqeasonchen