Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Consummate the functionality of RocketMQ based retry strategy under grpc and tcp protocols #4555

Open
1 of 5 tasks
pandaapo opened this issue Nov 15, 2023 · 3 comments
Open
1 of 5 tasks

[Enhancement] Consummate the functionality of RocketMQ based retry strategy under grpc and tcp protocols #4555

pandaapo opened this issue Nov 15, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pandaapo
Copy link
Member

pandaapo commented Nov 15, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

For the case of message consumption failure, the retry strategy implemented by EventMesh based on RocketMQ currently fully supports the HTTP protocol running mode of EventMesh, and the retry under the grpc and tcp protocols is waiting to be consummated.

对于消息消费失败的情况，目前EventMesh基于RocketMQ实现的重试策略，完整地支持EventMesh的http协议运行方式，grpc协议和tcp协议下的这种重试等待完善。

Describe the solution you'd like

task list

  • Consummate the functionality of RocketMQ based retry strategy under grpc protocol
  • Consummate the functionality of RocketMQ based retry strategy under tcp protocol

Welcome to claim the task you are interested in and create corresponding sub issue.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@pandaapo pandaapo added the enhancement New feature or request label Nov 15, 2023
@VishalMCF
Copy link
Contributor

@pandaapo Hi, I am new to the Eventmesh community. But I am interested in this task. If you can suggest some modules to explore then it will be helpful.

@pandaapo
Copy link
Member Author

You can refer to some of the content in this PR #4544. This pull request mainly implements the retry strategy based on RocketMQ, and also completes the use of this strategy under HTTP protocol. You can complete the use of this strategy for gRPC protocol, or TCP protocol, or both.

@github-actions github-actions bot added the Stale label Apr 6, 2024
@Pil0tXia Pil0tXia added help wanted Extra attention is needed and removed Stale labels Apr 6, 2024
@apache apache deleted a comment from github-actions bot Apr 6, 2024
@Pil0tXia Pil0tXia mentioned this issue Apr 6, 2024
Open
25 tasks
@epiao55
Copy link
Contributor

epiao55 commented Nov 20, 2024

I've noticed that the retry strategies in the retry module directly invoke the production methods of the storage module. Is it necessary to add support for the gRPC storage module in RocketMQ 5.x to address this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pandaapo @Pil0tXia @epiao55 @VishalMCF