Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Slack sink connector #4419

Closed
1 of 3 tasks
qqeasonchen opened this issue Aug 30, 2023 · 3 comments · Fixed by #4562
Closed
1 of 3 tasks

[Feature] Add Slack sink connector #4419

qqeasonchen opened this issue Aug 30, 2023 · 3 comments · Fixed by #4562
Labels

Comments

@qqeasonchen
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

Add Slack sink connector

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@HattoriHenzo
Copy link
Contributor

@qqeasonchen Does Slack shouldn't have a source connector?

@jihuayu
Copy link
Member

jihuayu commented Nov 16, 2023

I want to try this task. I will send a PR later.

@pandaapo
Copy link
Member

@jihuayu

Welcome to EventMesh community! This issue has been fixed by PR #4562.

However, this PR is just a preliminary implementation, and the functionality is relatively basic. You can try to improve and enrich the Slack sink, for example, by adding asynchronous interaction with Slack, or by adding retry functionality after sending messages to Slack fails, or by adding cache or multi-thread to avoid blocking caused by Slack's slow response, or by adding other features you can think of.

Of course, you can also try other issues.

欢迎来到EventMesh社区!该issue已经由PR #4562完成。
不过该PR只是初步实现,功能比较基础,您可以尝试完善和丰富该Slack sink,比如增加与Slack异步交互的方式、或者增加给Slack发送消息失败后的重试功能、或者使用缓存或多线程避免Slack响应慢导致的阻塞、或者其他您能想到的功能。
当然,您也可以尝试其他issue。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants