Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to use IdleStateHandler in Netty4 #3341

Merged
merged 12 commits into from
Jan 31, 2019
Merged

Start to use IdleStateHandler in Netty4 #3341

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b30e78e
start to use IdelStateHandler for netty4 client
beiwei30 Jan 24, 2019
49047b5
start to use IdleStateHandler when netty4 is enabled
beiwei30 Jan 25, 2019
f62a870
Merge branch 'master' into idle-state-handler
beiwei30 Jan 25, 2019
11f1158
unit test fix
beiwei30 Jan 25, 2019
a7b5789
fix checkstyle
beiwei30 Jan 25, 2019
a23e64d
add logging message
beiwei30 Jan 28, 2019
0a9bce3
use idle timeout instead of heartbeat interval
beiwei30 Jan 30, 2019
e71f82e
use try finally only when IdleStateEvent fires.
beiwei30 Jan 30, 2019
ed99204
no need to keep compat to 1.0.x
beiwei30 Jan 30, 2019
0f1c8c2
introduce a new interface, IdleSensible
beiwei30 Jan 30, 2019
e83885f
fix unit test
beiwei30 Jan 30, 2019
12ddca9
don't rely on RECONNECT_KEY, and give HEARTBEAT a default value
Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into idle-state-handler
  • Loading branch information
@beiwei30
beiwei30 authored Jan 25, 2019
commit f62a870c4aa63e445e18a56d2cb3aff0f04436d8
16 changes: 15 additions & 1 deletion ...g-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClientHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,18 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause)
NettyChannel.removeChannelIfDisconnected(ctx.channel());
}
}
}

/**
* build a bad request's response
*
* @param request the request
* @param t the throwable. In most cases, serialization fails.
* @return the response
*/
private static Response buildErrorResponse(Request request, Throwable t) {
Response response = new Response(request.getId(), request.getVersion());
response.setStatus(Response.BAD_REQUEST);
response.setErrorMessage(StringUtils.toString(t));
return response;
}
}
You are viewing a condensed version of this merge commit. You can view the full changes here.