Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression-test](fix) fix test_show_tablet.groovy bug running on mul… #46791

Merged
merged 1 commit into from
Jan 11, 2025
Merged

[regression-test](fix) fix test_show_tablet.groovy bug running on mul… #46791

merged 1 commit into from
Jan 11, 2025
+25 −7

Conversation

shuke987
Copy link
Collaborator

…ti-be cluster with force_olap_table_replication_num=3

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@shuke987
[regression-test](fix) fix test_show_tablet.groovy bug running on mul…
51d3c5d 
…ti-be cluster with force_olap_table_replication_num=3
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987
Copy link
Collaborator Author

run buildall

eldenmoon
eldenmoon approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@eldenmoon eldenmoon merged commit 46bd885 into apache:master Jan 11, 2025
29 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 11, 2025
@shuke987
[regression-test](fix) fix test_show_tablet.groovy bug running on mul… (
172530a 
#46791)
@github-actions github-actions bot mentioned this pull request Jan 11, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jan 11, 2025
@github-actions @shuke987
branch-3.0: [regression-test](fix) fix test_show_tablet.groovy bug ru…
15a3381 
…nning on mul… #46791 (#46809)

Cherry-picked from #46791

Co-authored-by: shuke <shuke@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@feifeifeimoon feifeifeimoon feifeifeimoon approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring

@starocean999 starocean999 Awaiting requested review from starocean999

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shuke987 @hello-stephen @feifeifeimoon @eldenmoon @dataroaring