Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [fix](ES catalog)Fix query long value exception with doc_value #46554 #46580

Merged
merged 1 commit into from
Jan 9, 2025
Merged

branch-3.0: [fix](ES catalog)Fix query long value exception with doc_value #46554 #46580

merged 1 commit into from
Jan 9, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2025

Cherry-picked from #46554

@qidaye
[fix](ES catalog)Fix query long value exception with doc_value (#46554)
c25e447 
Issue Number: close #46553

Problem Summary:

When parsing number value from pure_doc_value or array, we should get
the first value, not the whole array.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 8, 2025
@dataroaring dataroaring reopened this Jan 8, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40347 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c25e44713a57eecbb843cbce4b06e50278f971a1, data reload: false

------ Round 1 ----------------------------------
q1	17643	7390	7237	7237
q2	2067	179	174	174
q3	10685	1064	1196	1064
q4	10560	748	683	683
q5	7746	2833	2752	2752
q6	239	146	143	143
q7	965	631	599	599
q8	9378	1976	2087	1976
q9	6671	6495	6413	6413
q10	7014	2279	2310	2279
q11	474	269	250	250
q12	392	212	207	207
q13	17760	2973	2988	2973
q14	243	211	210	210
q15	558	513	522	513
q16	707	610	603	603
q17	970	566	621	566
q18	7223	6451	6893	6451
q19	1445	1096	990	990
q20	479	210	195	195
q21	4099	3095	3154	3095
q22	1124	1006	974	974
Total cold run time: 108442 ms
Total hot run time: 40347 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7266	7238	7182	7182
q2	327	235	231	231
q3	2893	2824	2935	2824
q4	2033	1773	1796	1773
q5	5759	5736	5794	5736
q6	232	140	142	140
q7	2251	1864	1773	1773
q8	3375	3599	3566	3566
q9	8839	8834	8875	8834
q10	3581	3541	3546	3541
q11	607	503	528	503
q12	835	613	588	588
q13	10206	3216	3234	3216
q14	308	272	268	268
q15	628	514	527	514
q16	727	694	669	669
q17	1845	1632	1600	1600
q18	8271	7921	7793	7793
q19	1688	1495	1596	1495
q20	2022	1848	1865	1848
q21	5630	5338	5328	5328
q22	1108	1037	1056	1037
Total cold run time: 70431 ms
Total hot run time: 60459 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198309 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c25e44713a57eecbb843cbce4b06e50278f971a1, data reload: false

query1	1284	903	897	897
query2	6490	2176	2111	2111
query3	10833	4273	4270	4270
query4	62198	28762	23542	23542
query5	5157	450	468	450
query6	403	163	175	163
query7	5521	316	315	315
query8	307	233	227	227
query9	8689	2742	2688	2688
query10	468	267	273	267
query11	17404	15209	15671	15209
query12	160	105	106	105
query13	1461	464	440	440
query14	10593	6716	7235	6716
query15	198	179	174	174
query16	7294	499	480	480
query17	1157	580	600	580
query18	1855	315	316	315
query19	212	171	160	160
query20	124	115	111	111
query21	218	106	107	106
query22	4632	4661	4636	4636
query23	35029	34348	35055	34348
query24	6363	3003	2967	2967
query25	555	435	412	412
query26	661	173	172	172
query27	1845	377	360	360
query28	4453	2497	2473	2473
query29	708	496	469	469
query30	242	192	173	173
query31	1016	833	818	818
query32	69	56	59	56
query33	424	296	283	283
query34	939	531	553	531
query35	846	747	729	729
query36	1073	982	958	958
query37	125	71	75	71
query38	4127	4121	3968	3968
query39	1531	1495	1496	1495
query40	210	101	103	101
query41	51	50	49	49
query42	117	106	98	98
query43	558	503	510	503
query44	1211	839	852	839
query45	191	170	174	170
query46	1137	728	703	703
query47	2002	1943	1968	1943
query48	474	380	380	380
query49	734	415	411	411
query50	864	426	429	426
query51	7420	7409	7268	7268
query52	107	90	97	90
query53	271	197	181	181
query54	575	454	450	450
query55	78	81	82	81
query56	253	248	252	248
query57	1250	1161	1201	1161
query58	218	208	214	208
query59	3403	3214	2994	2994
query60	286	252	251	251
query61	109	109	107	107
query62	775	667	646	646
query63	213	186	191	186
query64	1421	668	647	647
query65	3254	3176	3226	3176
query66	705	302	299	299
query67	15964	15821	15782	15782
query68	4255	583	552	552
query69	479	266	266	266
query70	1202	1115	1045	1045
query71	344	259	259	259
query72	6049	4339	4077	4077
query73	749	357	359	357
query74	10266	9197	8960	8960
query75	3381	2635	2683	2635
query76	1853	1083	1046	1046
query77	503	288	265	265
query78	10669	9678	9622	9622
query79	1511	596	606	596
query80	864	435	433	433
query81	513	242	243	242
query82	1249	115	121	115
query83	165	146	162	146
query84	283	81	76	76
query85	853	292	278	278
query86	319	299	303	299
query87	4448	4247	4272	4247
query88	3814	2420	2478	2420
query89	431	298	296	296
query90	2014	186	190	186
query91	174	147	149	147
query92	63	50	51	50
query93	2013	543	555	543
query94	755	289	304	289
query95	360	257	259	257
query96	612	286	284	284
query97	3331	3219	3205	3205
query98	209	211	200	200
query99	1594	1306	1273	1273
Total cold run time: 315840 ms
Total hot run time: 198309 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c25e44713a57eecbb843cbce4b06e50278f971a1, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.22	0.07	0.06
query4	1.62	0.11	0.11
query5	0.54	0.52	0.52
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.50
query10	0.57	0.56	0.57
query11	0.14	0.10	0.10
query12	0.15	0.14	0.11
query13	0.60	0.60	0.59
query14	2.96	2.89	3.01
query15	0.90	0.84	0.84
query16	0.40	0.40	0.37
query17	1.04	1.03	1.01
query18	0.24	0.22	0.21
query19	2.00	1.87	1.96
query20	0.02	0.01	0.01
query21	15.35	0.61	0.59
query22	2.84	2.22	1.85
query23	17.08	1.08	0.77
query24	3.25	1.16	2.01
query25	0.18	0.20	0.07
query26	0.59	0.16	0.14
query27	0.05	0.04	0.03
query28	9.55	1.11	1.07
query29	12.59	3.24	3.21
query30	0.24	0.06	0.06
query31	2.88	0.39	0.40
query32	3.23	0.46	0.47
query33	2.99	3.02	3.05
query34	16.88	4.43	4.48
query35	4.56	4.54	4.49
query36	0.67	0.50	0.50
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.69 s
Total hot run time: 33.11 s

@qidaye qidaye merged commit 1d2d031 into branch-3.0 Jan 9, 2025
21 of 22 checks passed
@qidaye qidaye deleted the auto-pick-46554-branch-3.0 branch January 9, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hello-stephen @doris-robot @qidaye @dataroaring