Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](group commit) support full prepare of group commit in nereids #46533

Merged
merged 4 commits into from
Jan 9, 2025
Merged

[fix](group commit) support full prepare of group commit in nereids #46533

merged 4 commits into from
Jan 9, 2025

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Jan 7, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32638 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3eadec31cdb32161c5a189dda07f43e2307c858a, data reload: false

------ Round 1 ----------------------------------
q1	17563	6174	6004	6004
q2	2063	292	169	169
q3	10604	1251	754	754
q4	10225	866	428	428
q5	7767	2160	1958	1958
q6	210	182	144	144
q7	890	754	596	596
q8	9246	1354	1159	1159
q9	5505	4987	4955	4955
q10	6811	2279	1862	1862
q11	483	273	258	258
q12	337	359	218	218
q13	17769	3650	3109	3109
q14	230	227	211	211
q15	565	502	491	491
q16	609	603	607	603
q17	564	838	335	335
q18	6868	6369	6476	6369
q19	2005	953	557	557
q20	294	309	192	192
q21	2786	2176	1956	1956
q22	365	333	310	310
Total cold run time: 103759 ms
Total hot run time: 32638 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6291	6179	6193	6179
q2	234	324	234	234
q3	2268	2616	2316	2316
q4	1413	1909	1404	1404
q5	4342	4752	4816	4752
q6	191	176	144	144
q7	2001	1950	1791	1791
q8	2623	2797	2705	2705
q9	7292	7210	7303	7210
q10	3054	3326	2842	2842
q11	579	511	491	491
q12	637	700	613	613
q13	3521	3889	3151	3151
q14	296	320	284	284
q15	563	503	507	503
q16	637	681	658	658
q17	1198	1742	1272	1272
q18	7765	7354	7329	7329
q19	815	1187	1053	1053
q20	2022	2076	1883	1883
q21	5688	5317	4897	4897
q22	615	603	612	603
Total cold run time: 54045 ms
Total hot run time: 52314 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196537 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3eadec31cdb32161c5a189dda07f43e2307c858a, data reload: false

query1	1323	935	923	923
query2	6169	2298	2287	2287
query3	10973	4703	4817	4703
query4	32936	23697	23566	23566
query5	4338	600	445	445
query6	295	191	193	191
query7	3999	491	310	310
query8	301	259	237	237
query9	9291	2769	2760	2760
query10	477	312	244	244
query11	18287	15475	15186	15186
query12	158	110	102	102
query13	1606	525	410	410
query14	10752	7566	6903	6903
query15	248	202	199	199
query16	8103	608	451	451
query17	1529	764	604	604
query18	2124	427	342	342
query19	208	194	177	177
query20	132	116	116	116
query21	212	143	119	119
query22	4771	4526	4429	4429
query23	37018	33592	33771	33592
query24	6326	2299	2333	2299
query25	523	450	384	384
query26	1040	257	150	150
query27	2266	475	354	354
query28	5284	2532	2495	2495
query29	569	536	414	414
query30	214	187	144	144
query31	994	909	843	843
query32	79	56	57	56
query33	521	345	305	305
query34	834	860	523	523
query35	825	848	762	762
query36	1003	1050	997	997
query37	130	96	97	96
query38	4359	4288	4119	4119
query39	1512	1485	1452	1452
query40	202	121	103	103
query41	45	40	44	40
query42	127	106	107	106
query43	527	515	488	488
query44	1374	827	821	821
query45	193	175	165	165
query46	870	1071	661	661
query47	2010	2013	1946	1946
query48	407	430	333	333
query49	733	489	406	406
query50	645	668	404	404
query51	7195	7026	7070	7026
query52	99	99	91	91
query53	228	257	188	188
query54	479	515	405	405
query55	77	77	78	77
query56	258	263	261	261
query57	1221	1239	1164	1164
query58	239	261	220	220
query59	3244	3177	3189	3177
query60	286	256	264	256
query61	110	107	107	107
query62	851	809	762	762
query63	232	191	185	185
query64	4370	1081	648	648
query65	3315	3276	3283	3276
query66	902	432	302	302
query67	16130	15710	15521	15521
query68	8622	710	509	509
query69	465	289	258	258
query70	1175	1152	1141	1141
query71	494	282	250	250
query72	6211	3835	3843	3835
query73	668	749	353	353
query74	10307	9278	8930	8930
query75	3962	3141	2729	2729
query76	3730	1197	796	796
query77	783	358	298	298
query78	10002	10044	9386	9386
query79	3652	836	592	592
query80	692	519	448	448
query81	484	268	225	225
query82	606	150	122	122
query83	193	212	155	155
query84	279	84	65	65
query85	751	344	307	307
query86	337	313	288	288
query87	4664	4626	4295	4295
query88	4218	2254	2227	2227
query89	438	334	299	299
query90	1818	188	185	185
query91	130	137	109	109
query92	68	54	50	50
query93	1535	875	530	530
query94	633	395	283	283
query95	329	265	261	261
query96	477	615	282	282
query97	2905	3029	2862	2862
query98	215	206	207	206
query99	1722	1571	1433	1433
Total cold run time: 300663 ms
Total hot run time: 196537 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3eadec31cdb32161c5a189dda07f43e2307c858a, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.04	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.40	0.43	0.42
query6	1.18	0.65	0.64
query7	0.03	0.02	0.01
query8	0.05	0.04	0.03
query9	0.60	0.49	0.51
query10	0.55	0.56	0.55
query11	0.14	0.10	0.10
query12	0.15	0.11	0.10
query13	0.61	0.61	0.60
query14	2.72	2.83	2.78
query15	0.89	0.83	0.82
query16	0.39	0.39	0.39
query17	1.02	0.96	1.01
query18	0.22	0.20	0.20
query19	1.97	1.82	1.96
query20	0.01	0.02	0.01
query21	15.36	0.91	0.57
query22	0.76	1.01	0.63
query23	15.11	1.42	0.52
query24	3.26	0.92	2.06
query25	0.18	0.07	0.11
query26	0.27	0.15	0.13
query27	0.07	0.05	0.06
query28	13.72	1.51	1.06
query29	12.55	4.08	3.38
query30	0.25	0.09	0.06
query31	2.83	0.61	0.38
query32	3.22	0.54	0.45
query33	3.16	3.12	3.10
query34	16.41	5.11	4.43
query35	4.47	4.44	4.48
query36	0.63	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.61 s
Total hot run time: 31.11 s

morrySnow
morrySnow previously approved these changes Jan 7, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mymeiyi mymeiyi dismissed stale reviews from eldenmoon and morrySnow via 95d97fb January 8, 2025 03:38
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 8, 2025
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32592 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d47e35ef42937d533841ff504f9aee011af569a3, data reload: false

------ Round 1 ----------------------------------
q1	17589	6192	6060	6060
q2	2045	330	170	170
q3	10384	1219	747	747
q4	10200	869	441	441
q5	7538	2201	1986	1986
q6	204	185	144	144
q7	885	756	586	586
q8	9249	1385	1193	1193
q9	5280	4899	4927	4899
q10	6730	2319	1881	1881
q11	490	280	257	257
q12	335	360	224	224
q13	17778	3695	2967	2967
q14	240	242	225	225
q15	573	508	502	502
q16	627	612	601	601
q17	562	848	322	322
q18	7071	6438	6470	6438
q19	3374	964	525	525
q20	296	307	186	186
q21	2795	2179	1934	1934
q22	366	334	304	304
Total cold run time: 104611 ms
Total hot run time: 32592 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6355	6228	6204	6204
q2	231	329	229	229
q3	2275	2652	2340	2340
q4	1440	1830	1350	1350
q5	4343	4718	4889	4718
q6	185	177	140	140
q7	2088	2027	1834	1834
q8	2654	2811	2718	2718
q9	7351	7297	7378	7297
q10	3053	3394	2727	2727
q11	583	501	486	486
q12	646	787	643	643
q13	3474	3864	3285	3285
q14	284	326	277	277
q15	576	526	489	489
q16	655	672	638	638
q17	1207	1743	1258	1258
q18	7662	7437	7458	7437
q19	836	1089	1116	1089
q20	2052	2066	1900	1900
q21	5735	5108	4938	4938
q22	605	607	571	571
Total cold run time: 54290 ms
Total hot run time: 52568 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194821 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d47e35ef42937d533841ff504f9aee011af569a3, data reload: false

query1	1277	939	917	917
query2	6208	2325	2433	2325
query3	10983	4823	4850	4823
query4	33338	23497	23321	23321
query5	5003	609	464	464
query6	285	194	191	191
query7	3983	490	301	301
query8	293	242	235	235
query9	9516	2768	2744	2744
query10	496	308	251	251
query11	18016	15376	15084	15084
query12	165	110	108	108
query13	1658	560	407	407
query14	10643	6539	7079	6539
query15	225	215	191	191
query16	7998	633	480	480
query17	1539	766	596	596
query18	2115	424	328	328
query19	205	190	161	161
query20	129	120	156	120
query21	207	124	111	111
query22	4483	4387	4304	4304
query23	34522	34074	33699	33699
query24	6652	2244	2307	2244
query25	486	464	398	398
query26	1119	278	159	159
query27	2635	470	350	350
query28	5663	2528	2505	2505
query29	686	556	432	432
query30	211	183	145	145
query31	954	891	808	808
query32	67	60	61	60
query33	480	347	313	313
query34	763	841	533	533
query35	819	807	774	774
query36	986	1048	916	916
query37	111	93	74	74
query38	4250	4150	4391	4150
query39	1476	1434	1427	1427
query40	199	129	115	115
query41	45	46	44	44
query42	116	109	105	105
query43	529	534	518	518
query44	1349	872	850	850
query45	181	177	168	168
query46	889	1069	676	676
query47	1878	1877	1871	1871
query48	392	407	339	339
query49	750	473	404	404
query50	654	650	393	393
query51	7219	7093	7064	7064
query52	109	95	95	95
query53	230	252	194	194
query54	487	503	422	422
query55	78	83	82	82
query56	260	288	246	246
query57	1207	1206	1146	1146
query58	248	233	236	233
query59	3134	3397	3187	3187
query60	265	262	258	258
query61	108	104	131	104
query62	846	810	709	709
query63	221	192	189	189
query64	4068	1036	675	675
query65	3332	3253	3250	3250
query66	747	401	300	300
query67	16116	15656	15457	15457
query68	8733	699	507	507
query69	431	276	247	247
query70	1184	1056	1147	1056
query71	418	290	251	251
query72	6443	3868	3838	3838
query73	644	759	368	368
query74	9923	9101	8524	8524
query75	4302	3144	2640	2640
query76	4067	1179	736	736
query77	762	361	268	268
query78	10159	10170	9314	9314
query79	2964	787	618	618
query80	598	520	435	435
query81	494	265	228	228
query82	638	146	118	118
query83	163	163	145	145
query84	235	90	72	72
query85	776	423	298	298
query86	363	321	295	295
query87	4378	4533	4192	4192
query88	4522	2274	2192	2192
query89	414	327	292	292
query90	1839	193	195	193
query91	135	135	107	107
query92	67	56	54	54
query93	1731	891	526	526
query94	620	394	287	287
query95	324	267	260	260
query96	500	612	288	288
query97	2852	2958	2829	2829
query98	219	201	195	195
query99	1637	1524	1366	1366
Total cold run time: 298837 ms
Total hot run time: 194821 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.74 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d47e35ef42937d533841ff504f9aee011af569a3, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.11
query5	0.42	0.44	0.42
query6	1.18	0.66	0.66
query7	0.02	0.02	0.01
query8	0.03	0.04	0.03
query9	0.59	0.51	0.49
query10	0.55	0.57	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	2.71	2.77	2.79
query15	0.89	0.83	0.84
query16	0.38	0.38	0.36
query17	1.07	1.07	1.03
query18	0.23	0.21	0.21
query19	1.89	1.79	2.00
query20	0.02	0.01	0.01
query21	15.39	0.95	0.57
query22	0.76	0.97	0.78
query23	15.00	1.40	0.56
query24	3.01	1.48	1.36
query25	0.21	0.23	0.08
query26	0.20	0.15	0.14
query27	0.05	0.05	0.05
query28	13.87	1.54	1.05
query29	12.62	3.90	3.21
query30	0.25	0.10	0.07
query31	2.82	0.61	0.38
query32	3.23	0.55	0.45
query33	3.04	3.09	3.10
query34	16.76	5.09	4.49
query35	4.48	4.49	4.48
query36	0.67	0.51	0.48
query37	0.08	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.65 s
Total hot run time: 31.74 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32856 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ad6d1163e985acb80f3d2505a50525992d47ee09, data reload: false

------ Round 1 ----------------------------------
q1	17604	6327	6102	6102
q2	2055	310	166	166
q3	10441	1242	742	742
q4	10272	863	443	443
q5	8724	2167	1925	1925
q6	211	181	150	150
q7	906	771	607	607
q8	9241	1356	1136	1136
q9	5224	4898	4879	4879
q10	6748	2298	1842	1842
q11	470	278	270	270
q12	344	360	225	225
q13	17863	3762	3206	3206
q14	242	253	225	225
q15	565	498	495	495
q16	627	612	586	586
q17	579	868	352	352
q18	7137	6380	6462	6380
q19	1931	978	559	559
q20	305	320	198	198
q21	2785	2167	2052	2052
q22	365	333	316	316
Total cold run time: 104639 ms
Total hot run time: 32856 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6267	6261	6238	6238
q2	234	327	233	233
q3	2255	2646	2273	2273
q4	1400	1831	1356	1356
q5	4269	4696	4869	4696
q6	186	182	145	145
q7	2035	1952	1836	1836
q8	2663	2829	2707	2707
q9	7227	7248	7255	7248
q10	3076	3369	2756	2756
q11	562	533	488	488
q12	653	761	635	635
q13	3454	3867	3300	3300
q14	279	304	269	269
q15	587	519	498	498
q16	652	695	648	648
q17	1229	1734	1274	1274
q18	7621	7598	7221	7221
q19	845	1134	1124	1124
q20	2012	2058	1955	1955
q21	5701	5203	4979	4979
q22	620	617	589	589
Total cold run time: 53827 ms
Total hot run time: 52468 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194528 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ad6d1163e985acb80f3d2505a50525992d47ee09, data reload: false

query1	1278	946	924	924
query2	6460	2266	2307	2266
query3	11127	4636	4809	4636
query4	33051	23502	23352	23352
query5	3708	592	449	449
query6	279	223	190	190
query7	3995	488	312	312
query8	303	250	232	232
query9	9221	2784	2735	2735
query10	470	306	251	251
query11	17775	15217	14916	14916
query12	157	114	105	105
query13	1587	542	415	415
query14	9237	7464	7418	7418
query15	255	206	205	205
query16	8122	636	514	514
query17	1566	789	599	599
query18	2130	422	330	330
query19	228	183	165	165
query20	124	113	112	112
query21	206	134	107	107
query22	4593	4617	4381	4381
query23	33955	32972	33142	32972
query24	6354	2336	2392	2336
query25	503	473	399	399
query26	1040	270	150	150
query27	2231	477	331	331
query28	5353	2517	2511	2511
query29	727	553	418	418
query30	208	180	146	146
query31	963	900	782	782
query32	86	59	55	55
query33	492	328	315	315
query34	769	846	523	523
query35	819	829	745	745
query36	1032	1019	976	976
query37	123	100	77	77
query38	4091	4175	4063	4063
query39	1496	1448	1442	1442
query40	201	124	112	112
query41	47	47	42	42
query42	121	104	107	104
query43	528	525	514	514
query44	1336	841	852	841
query45	181	176	161	161
query46	866	1063	661	661
query47	1959	1893	1850	1850
query48	385	414	350	350
query49	817	499	395	395
query50	638	684	412	412
query51	6940	7037	6885	6885
query52	104	100	91	91
query53	219	256	185	185
query54	484	499	413	413
query55	91	77	79	77
query56	256	254	247	247
query57	1212	1187	1145	1145
query58	236	226	227	226
query59	3197	3190	3038	3038
query60	270	280	281	280
query61	113	115	104	104
query62	831	785	724	724
query63	233	188	188	188
query64	4298	1028	653	653
query65	3275	3298	3170	3170
query66	1091	401	301	301
query67	16254	15713	15384	15384
query68	9811	692	511	511
query69	506	295	262	262
query70	1236	1102	1022	1022
query71	418	282	253	253
query72	6213	3965	3830	3830
query73	658	744	365	365
query74	10378	8993	8798	8798
query75	4387	3147	2677	2677
query76	4619	1167	775	775
query77	839	362	274	274
query78	10053	10252	9326	9326
query79	3074	823	597	597
query80	608	503	431	431
query81	477	272	220	220
query82	611	151	123	123
query83	165	173	146	146
query84	237	88	141	88
query85	774	348	308	308
query86	358	322	293	293
query87	4431	4373	4236	4236
query88	4249	2238	2222	2222
query89	408	329	289	289
query90	1869	193	187	187
query91	133	133	105	105
query92	67	54	53	53
query93	1239	870	528	528
query94	650	402	297	297
query95	332	260	248	248
query96	477	616	286	286
query97	2846	2945	2801	2801
query98	225	200	208	200
query99	1610	1486	1369	1369
Total cold run time: 296255 ms
Total hot run time: 194528 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.39 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ad6d1163e985acb80f3d2505a50525992d47ee09, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.61	0.10	0.11
query5	0.42	0.40	0.41
query6	1.17	0.65	0.66
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.49	0.50
query10	0.55	0.55	0.55
query11	0.15	0.11	0.10
query12	0.13	0.11	0.11
query13	0.60	0.60	0.60
query14	2.75	2.74	2.81
query15	0.89	0.82	0.81
query16	0.40	0.37	0.38
query17	1.07	1.05	1.04
query18	0.23	0.21	0.20
query19	1.92	1.86	1.99
query20	0.02	0.01	0.01
query21	15.36	0.92	0.56
query22	0.76	0.75	0.67
query23	15.32	1.45	0.54
query24	3.28	1.91	0.98
query25	0.24	0.13	0.14
query26	0.29	0.15	0.13
query27	0.05	0.07	0.04
query28	13.99	1.51	1.05
query29	12.55	3.88	3.27
query30	0.25	0.09	0.07
query31	2.84	0.59	0.39
query32	3.24	0.55	0.46
query33	3.04	3.09	3.08
query34	16.78	5.19	4.53
query35	4.49	4.56	4.51
query36	0.84	0.48	0.47
query37	0.10	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.12
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.74 s
Total hot run time: 31.39 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 8, 2025

run external

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 9, 2025
eldenmoon
eldenmoon approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 75ef6bd into apache:master Jan 9, 2025
25 of 26 checks passed
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Jan 10, 2025
@mymeiyi
[fix](group commit) support full prepare of group commit in nereids (a…
b6c4e3b 
…pache#46533)
@mymeiyi mymeiyi mentioned this pull request Jan 10, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jan 13, 2025
@mymeiyi
[fix](group commit) support full prepare of group commit in nereids (#…
689391c 
…46533) (#46742)

pick #46533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mymeiyi @Thearas @doris-robot @eldenmoon @morrySnow @dataroaring