[chore](session) remove some unused session variables #45585

zhangstar333 · 2024-12-18T07:24:29Z

What problem does this PR solve?

remove some unused session variables

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

zhangstar333 · 2024-12-18T07:24:38Z

run buildall

hello-stephen · 2024-12-18T07:24:42Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

github-actions · 2024-12-18T07:25:16Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors


'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In gensrc/script/gen_build_version.sh line 38:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.


In gensrc/script/gen_build_version.sh line 228:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.

For more information:
  https://www.shellcheck.net/wiki/SC2071 -- > is for string comparisons. Use ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.

shfmt errors

'shfmt ' found no issues.

github-actions · 2024-12-18T07:28:53Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-12-18T08:38:27Z

TeamCity be ut coverage result:
Function Coverage: 38.88% (10132/26063)
Line Coverage: 29.78% (85140/285901)
Region Coverage: 28.83% (43674/151493)
Branch Coverage: 25.37% (22188/87460)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e010d6f7849ec40708092fb24509023c83b291e8_e010d6f7849ec40708092fb24509023c83b291e8/report/index.html

doris-robot · 2024-12-18T08:55:06Z

TPC-H: Total hot run time: 41530 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e010d6f7849ec40708092fb24509023c83b291e8, data reload: false

------ Round 1 ----------------------------------
q1	17582	8046	7729	7729
q2	2045	178	198	178
q3	10675	1167	1232	1167
q4	10560	776	818	776
q5	7653	2918	2801	2801
q6	263	150	143	143
q7	1104	639	599	599
q8	9272	1947	1989	1947
q9	7015	6829	6828	6828
q10	7066	2394	2361	2361
q11	470	260	264	260
q12	479	221	217	217
q13	17778	2989	2917	2917
q14	252	216	212	212
q15	570	503	484	484
q16	667	601	583	583
q17	1021	555	548	548
q18	7341	6805	6856	6805
q19	1355	1031	1174	1031
q20	490	184	183	183
q21	4438	3513	3449	3449
q22	384	318	312	312
Total cold run time: 108480 ms
Total hot run time: 41530 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7768	7710	7763	7710
q2	346	237	241	237
q3	3224	3069	3087	3069
q4	2238	1914	1852	1852
q5	5694	5828	5820	5820
q6	260	151	148	148
q7	2368	1808	1800	1800
q8	3640	3807	3743	3743
q9	9169	9102	9138	9102
q10	3742	3689	3692	3689
q11	621	500	519	500
q12	851	595	608	595
q13	13434	3203	3096	3096
q14	301	288	289	288
q15	565	521	499	499
q16	739	657	650	650
q17	2013	1735	1740	1735
q18	8351	7794	7632	7632
q19	1931	1746	1743	1743
q20	2175	1833	1941	1833
q21	5955	5729	5637	5637
q22	657	567	564	564
Total cold run time: 76042 ms
Total hot run time: 61942 ms

doris-robot · 2024-12-18T09:07:21Z

TPC-DS: Total hot run time: 195791 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e010d6f7849ec40708092fb24509023c83b291e8, data reload: false

query1	1241	959	991	959
query2	6239	2327	2381	2327
query3	11070	4867	4809	4809
query4	33243	23325	23489	23325
query5	3571	465	478	465
query6	263	177	171	171
query7	3977	300	297	297
query8	287	230	227	227
query9	9324	2738	2716	2716
query10	445	269	239	239
query11	17818	15200	15164	15164
query12	146	99	102	99
query13	1554	434	405	405
query14	9090	7080	6660	6660
query15	246	196	217	196
query16	8077	489	485	485
query17	1537	600	570	570
query18	2185	302	314	302
query19	231	157	164	157
query20	122	116	111	111
query21	206	107	109	107
query22	4794	4451	4514	4451
query23	35290	33956	33303	33303
query24	10536	2600	2608	2600
query25	555	402	419	402
query26	792	158	165	158
query27	2644	336	340	336
query28	7727	2512	2493	2493
query29	712	433	459	433
query30	239	160	157	157
query31	1039	854	840	840
query32	98	57	56	56
query33	785	312	299	299
query34	989	532	516	516
query35	886	769	756	756
query36	1099	923	953	923
query37	126	85	72	72
query38	4182	4091	4080	4080
query39	1495	1493	1465	1465
query40	210	99	99	99
query41	44	43	48	43
query42	110	109	101	101
query43	545	486	486	486
query44	1295	842	828	828
query45	187	170	167	167
query46	1207	764	754	754
query47	2004	1953	1956	1953
query48	428	340	322	322
query49	989	415	387	387
query50	855	407	391	391
query51	7381	7243	7205	7205
query52	119	102	95	95
query53	263	181	182	181
query54	1299	440	409	409
query55	91	89	82	82
query56	261	265	237	237
query57	1299	1157	1179	1157
query58	231	234	227	227
query59	3256	3087	2965	2965
query60	274	259	252	252
query61	109	106	107	106
query62	865	694	659	659
query63	220	190	182	182
query64	3917	685	645	645
query65	3285	3204	3241	3204
query66	841	309	323	309
query67	16041	15545	15488	15488
query68	5003	568	556	556
query69	560	260	245	245
query70	1230	1103	1124	1103
query71	457	246	253	246
query72	6917	4066	4037	4037
query73	785	441	366	366
query74	9978	8815	8893	8815
query75	3442	2640	2658	2640
query76	3681	1169	1183	1169
query77	638	303	307	303
query78	10309	9398	9508	9398
query79	2210	592	613	592
query80	891	422	437	422
query81	545	233	231	231
query82	1177	122	120	120
query83	243	144	148	144
query84	239	71	73	71
query85	1545	308	303	303
query86	468	305	297	297
query87	4461	4508	4317	4317
query88	3826	2215	2176	2176
query89	439	290	292	290
query90	2031	190	191	190
query91	145	108	104	104
query92	67	50	52	50
query93	2457	545	558	545
query94	899	302	298	298
query95	350	250	251	250
query96	632	290	280	280
query97	2837	2667	2683	2667
query98	232	193	202	193
query99	1575	1308	1316	1308
Total cold run time: 302755 ms
Total hot run time: 195791 ms

doris-robot · 2024-12-18T09:13:07Z

ClickBench: Total hot run time: 33.96 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e010d6f7849ec40708092fb24509023c83b291e8, data reload: false

query1	0.03	0.03	0.03
query2	0.09	0.04	0.05
query3	0.23	0.05	0.06
query4	1.66	0.09	0.09
query5	0.43	0.41	0.41
query6	1.16	0.66	0.67
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.54	0.51	0.50
query10	0.56	0.56	0.55
query11	0.17	0.12	0.12
query12	0.16	0.13	0.13
query13	0.62	0.59	0.60
query14	2.76	2.88	2.73
query15	0.91	0.84	0.83
query16	0.39	0.38	0.39
query17	1.07	1.09	1.08
query18	0.18	0.18	0.18
query19	1.97	1.86	2.03
query20	0.01	0.01	0.01
query21	15.36	0.67	0.65
query22	4.60	6.89	2.30
query23	18.30	1.44	1.49
query24	2.18	0.22	0.21
query25	0.15	0.09	0.09
query26	0.26	0.18	0.18
query27	0.08	0.08	0.08
query28	13.28	1.16	1.14
query29	12.62	3.36	3.33
query30	0.25	0.06	0.06
query31	2.84	0.41	0.40
query32	3.24	0.49	0.49
query33	3.08	3.12	3.11
query34	16.90	4.56	4.50
query35	4.61	4.58	4.58
query36	0.66	0.50	0.48
query37	0.20	0.15	0.15
query38	0.15	0.15	0.15
query39	0.06	0.04	0.04
query40	0.16	0.14	0.14
query41	0.09	0.05	0.06
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 112.19 s
Total hot run time: 33.96 s

zhangstar333 · 2025-01-06T06:18:28Z

run buildall

doris-robot · 2025-01-06T07:42:05Z

TeamCity be ut coverage result:
Function Coverage: 38.89% (10129/26046)
Line Coverage: 29.93% (85715/286398)
Region Coverage: 29.02% (43733/150674)
Branch Coverage: 25.56% (22319/87322)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2463ade88b24c2790dbb0b24effba77d24342d04_2463ade88b24c2790dbb0b24effba77d24342d04/report/index.html

doris-robot · 2025-01-06T07:48:11Z

TPC-H: Total hot run time: 32745 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2463ade88b24c2790dbb0b24effba77d24342d04, data reload: false

------ Round 1 ----------------------------------
q1	17713	6078	5990	5990
q2	2047	313	177	177
q3	10490	1259	764	764
q4	10215	877	439	439
q5	7672	2147	2002	2002
q6	210	181	151	151
q7	898	772	601	601
q8	9230	1359	1201	1201
q9	5103	4986	4953	4953
q10	6764	2332	1874	1874
q11	468	295	256	256
q12	342	363	221	221
q13	17755	3736	3101	3101
q14	235	230	212	212
q15	560	491	485	485
q16	628	616	589	589
q17	564	860	344	344
q18	7145	6516	6352	6352
q19	2117	966	556	556
q20	304	313	188	188
q21	2825	2177	1986	1986
q22	375	338	303	303
Total cold run time: 103660 ms
Total hot run time: 32745 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6317	6264	6213	6213
q2	241	323	234	234
q3	2246	2659	2331	2331
q4	1434	1864	1439	1439
q5	4363	4782	4864	4782
q6	189	179	149	149
q7	2061	2009	1784	1784
q8	2674	2795	2732	2732
q9	7305	7349	7271	7271
q10	3042	3347	2847	2847
q11	578	511	500	500
q12	636	717	628	628
q13	3547	3865	3262	3262
q14	298	310	278	278
q15	561	511	513	511
q16	642	684	652	652
q17	1218	1729	1271	1271
q18	7915	7606	7494	7494
q19	822	1178	1105	1105
q20	2019	2052	1909	1909
q21	5753	5165	4944	4944
q22	627	618	610	610
Total cold run time: 54488 ms
Total hot run time: 52946 ms

doris-robot · 2025-01-06T08:00:34Z

TPC-DS: Total hot run time: 197131 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2463ade88b24c2790dbb0b24effba77d24342d04, data reload: false

query1	1293	921	945	921
query2	6301	2351	2339	2339
query3	11163	4975	4770	4770
query4	33281	23771	23564	23564
query5	4341	616	492	492
query6	285	209	190	190
query7	3986	501	309	309
query8	314	255	246	246
query9	9417	2647	2638	2638
query10	472	319	259	259
query11	18396	15800	15168	15168
query12	162	112	108	108
query13	1640	557	427	427
query14	11536	7178	7984	7178
query15	239	205	214	205
query16	7991	638	470	470
query17	1558	782	592	592
query18	2032	408	340	340
query19	204	184	159	159
query20	124	123	115	115
query21	216	133	136	133
query22	4436	4586	4457	4457
query23	34793	33468	33398	33398
query24	6186	2375	2391	2375
query25	471	466	389	389
query26	891	291	161	161
query27	1960	467	340	340
query28	5237	2437	2434	2434
query29	607	568	433	433
query30	213	184	153	153
query31	968	917	870	870
query32	74	61	59	59
query33	480	360	309	309
query34	775	862	513	513
query35	828	869	779	779
query36	1019	1054	968	968
query37	116	106	91	91
query38	4332	4305	4195	4195
query39	1546	1497	1466	1466
query40	207	120	109	109
query41	46	48	44	44
query42	126	111	103	103
query43	532	552	505	505
query44	1413	846	820	820
query45	194	180	180	180
query46	934	1064	702	702
query47	2000	1961	1917	1917
query48	404	426	331	331
query49	708	490	422	422
query50	699	686	395	395
query51	7271	7193	7155	7155
query52	106	102	97	97
query53	246	278	195	195
query54	520	521	425	425
query55	86	93	82	82
query56	281	279	259	259
query57	1273	1270	1184	1184
query58	229	243	223	223
query59	3300	3413	3236	3236
query60	286	278	261	261
query61	119	103	106	103
query62	865	817	749	749
query63	241	197	199	197
query64	3239	1049	692	692
query65	3356	3281	3308	3281
query66	777	411	313	313
query67	16436	15844	15520	15520
query68	8733	715	511	511
query69	482	309	258	258
query70	1260	1173	1137	1137
query71	453	306	256	256
query72	6242	3880	3912	3880
query73	642	775	372	372
query74	10191	9017	8839	8839
query75	4623	3133	2685	2685
query76	4237	1226	896	896
query77	790	370	286	286
query78	10589	9939	9346	9346
query79	3583	857	585	585
query80	732	541	472	472
query81	477	266	229	229
query82	605	155	118	118
query83	194	159	150	150
query84	279	93	73	73
query85	785	373	303	303
query86	349	324	312	312
query87	4408	4596	4327	4327
query88	4654	2178	2156	2156
query89	418	329	296	296
query90	1876	188	188	188
query91	150	137	104	104
query92	71	58	55	55
query93	1619	845	538	538
query94	657	383	294	294
query95	338	299	252	252
query96	476	623	282	282
query97	2924	3014	2768	2768
query98	216	200	203	200
query99	1726	1576	1450	1450
Total cold run time: 300556 ms
Total hot run time: 197131 ms

doris-robot · 2025-01-06T08:05:54Z

ClickBench: Total hot run time: 31.46 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2463ade88b24c2790dbb0b24effba77d24342d04, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.65	0.08	0.08
query5	0.41	0.40	0.39
query6	1.17	0.66	0.66
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.54	0.49	0.50
query10	0.56	0.58	0.54
query11	0.18	0.11	0.12
query12	0.16	0.13	0.12
query13	0.62	0.59	0.60
query14	2.84	2.75	2.74
query15	0.90	0.84	0.84
query16	0.38	0.38	0.40
query17	1.07	1.07	1.02
query18	0.20	0.19	0.20
query19	1.87	1.78	2.01
query20	0.02	0.01	0.01
query21	15.35	0.96	0.65
query22	0.78	0.78	0.71
query23	15.09	1.49	0.67
query24	2.25	0.35	0.22
query25	0.14	0.08	0.08
query26	0.28	0.19	0.18
query27	0.08	0.08	0.08
query28	13.38	1.77	1.13
query29	12.64	4.05	3.35
query30	0.24	0.08	0.06
query31	2.84	0.58	0.39
query32	3.22	0.58	0.46
query33	3.09	3.14	3.12
query34	16.80	5.17	4.53
query35	4.60	4.56	4.56
query36	0.82	0.50	0.50
query37	0.20	0.16	0.16
query38	0.15	0.15	0.15
query39	0.05	0.04	0.05
query40	0.16	0.13	0.13
query41	0.10	0.06	0.06
query42	0.06	0.05	0.05
query43	0.05	0.05	0.05
Total cold run time: 105.34 s
Total hot run time: 31.46 s

HappenLee

LGTM

github-actions · 2025-01-07T11:06:46Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-01-07T11:06:47Z

PR approved by anyone and no changes requested.

### What problem does this PR solve? Problem Summary: in this PR #45585 ignore the session variable enable_local_exchange so it's couldn't get result use show variables command. change to another session to test command

[chore](session) remove some unused session variables

2463ade

zhangstar333 force-pushed the perf_of_analytic branch from e010d6f to 2463ade Compare January 6, 2025 06:18

HappenLee approved these changes Jan 7, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 7, 2025

github-actions bot added the reviewed label Jan 7, 2025

zclllyybb approved these changes Jan 7, 2025

View reviewed changes

HappenLee merged commit a764505 into apache:master Jan 8, 2025
24 of 27 checks passed

HappenLee added the dev/3.0.x label Jan 8, 2025

github-actions bot added the dev/3.0.x-conflict label Jan 8, 2025

zhangstar333 mentioned this pull request Jan 9, 2025

[fix](test) fix set_and_unset_variable_command test case failed #46678

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chore](session) remove some unused session variables #45585

[chore](session) remove some unused session variables #45585

zhangstar333 commented Dec 18, 2024 •

edited

Loading

zhangstar333 commented Dec 18, 2024

hello-stephen commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

doris-robot commented Dec 18, 2024

doris-robot commented Dec 18, 2024

doris-robot commented Dec 18, 2024

doris-robot commented Dec 18, 2024

zhangstar333 commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

HappenLee left a comment

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

[chore](session) remove some unused session variables #45585

[chore](session) remove some unused session variables #45585

Conversation

zhangstar333 commented Dec 18, 2024 • edited Loading

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

zhangstar333 commented Dec 18, 2024

hello-stephen commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

sh-checker report

github-actions bot commented Dec 18, 2024

doris-robot commented Dec 18, 2024

doris-robot commented Dec 18, 2024

doris-robot commented Dec 18, 2024

doris-robot commented Dec 18, 2024

zhangstar333 commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

doris-robot commented Jan 6, 2025

HappenLee left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

zhangstar333 commented Dec 18, 2024 •

edited

Loading

`sh-checker report`