Introduce UnsafeFlag to manage disabling ArrayData validation
#7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jan 27, 2025
| Self(false) | ||
| } | ||
|
|
||
| #[inline] |
There was a problem hiding this comment.
the point of structure is that the compiler enforces it can only ever be set to true via unsafe code
alamb
changed the title
UnsafeFlag to manage disabling validationUnsafeFlag to manage disabling ArrayData validation
tustvold
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ArrayDataBuilder: validate and align #6966Rationale for this change
As mentioned previously, the management of disabling validation must be handled very carefully to ensure the overall API remains
safe.@tustvold suggested an approach that adds additional compile time checking in #7006 (review), in the form of an an extra layer of protection when modifying the flags. I thought it was a great idea so figured I would start with it here
What changes are included in this PR?
UnsafeFlagtypeArrayDataBuilderto use itAre there any user-facing changes?
No, this is entirely internal