Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44360: [C#] Fix Flight DoExchange incompatibility with C++ implementation #44424

Merged
merged 5 commits into from
Oct 16, 2024
Merged

GH-44360: [C#] Fix Flight DoExchange incompatibility with C++ implementation #44424

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
561e217
Add C++ Flight integration test for do_exchange
adamreeve Oct 14, 2024
aa6ec7d
Add C# do_exchange integration test
adamreeve Oct 14, 2024
734f81e
Handle clients sending schema after the first flight data stream message
adamreeve Oct 9, 2024
82fbd0b
Add missing license header
adamreeve Oct 15, 2024
05080da
Update status doc
adamreeve Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update status doc
  • Loading branch information
@adamreeve
adamreeve committed Oct 15, 2024
commit 05080da3a3e5eb53ae8bc70d34cddd84cd3401e6
19 changes: 9 additions & 10 deletions docs/source/status.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,15 +208,15 @@ Supported features in the gRPC transport:
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Flight RPC Feature | C++ | Java | Go | JS | C# | Rust | Julia | Swift |
+============================================+=======+=======+=======+====+=======+=======+=======+=======+
| All RPC methods | ✓ | ✓ | ✓ | | ✓ (1) | ✓ | | |
| All RPC methods | ✓ | ✓ | ✓ | | ✓ | ✓ | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Authentication handlers | ✓ | ✓ | ✓ | | ✓ (2) | ✓ | | |
| Authentication handlers | ✓ | ✓ | ✓ | | ✓ (1) | ✓ | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Call timeouts | ✓ | ✓ | ✓ | | | ✓ | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Call cancellation | ✓ | ✓ | ✓ | | | ✓ | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Concurrent client calls (3) | ✓ | ✓ | ✓ | | ✓ | ✓ | | |
| Concurrent client calls (2) | ✓ | ✓ | ✓ | | ✓ | ✓ | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Custom middleware | ✓ | ✓ | ✓ | | | ✓ | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
Expand All @@ -228,15 +228,15 @@ Supported features in the UCX transport:
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Flight RPC Feature | C++ | Java | Go | JS | C# | Rust | Julia | Swift |
+============================================+=======+=======+=======+====+=======+=======+=======+=======+
| All RPC methods | ✓ (4) | | | | | | | |
| All RPC methods | ✓ (3) | | | | | | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Authentication handlers | | | | | | | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Call timeouts | | | | | | | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Call cancellation | | | | | | | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Concurrent client calls | ✓ (5) | | | | | | | |
| Concurrent client calls | ✓ (4) | | | | | | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
| Custom middleware | | | | | | | | |
+--------------------------------------------+-------+-------+-------+----+-------+-------+-------+-------+
Expand All @@ -245,11 +245,10 @@ Supported features in the UCX transport:

Notes:

* \(1) No support for Handshake or DoExchange.
* \(2) Support using AspNetCore authentication handlers.
* \(3) Whether a single client can support multiple concurrent calls.
* \(4) Only support for DoExchange, DoGet, DoPut, and GetFlightInfo.
* \(5) Each concurrent call is a separate connection to the server
* \(1) Support using AspNetCore authentication handlers.
* \(2) Whether a single client can support multiple concurrent calls.
* \(3) Only support for DoExchange, DoGet, DoPut, and GetFlightInfo.
* \(4) Each concurrent call is a separate connection to the server
(unlike gRPC where concurrent calls are multiplexed over a single
connection). This will generally provide better throughput but
consumes more resources both on the server and the client.
Expand Down
Loading