GH-40816: [C++] Security checks and relaxing hashjoin batch rows size. #40817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add an assertion to ensure that batch_prtn_ranges is incremented and relax the rows check of partition eval.
|
|
pitrou
requested changes
Mar 27, 2024
|
Is there any situation where these checks might fail or is this purely checking internal invariants? |
github-actions
bot
added
awaiting committer review
I'm not sure if it exists. At least in our scenario, setting rows to a number between 1<<15 and 1<<16-1 is no problem. |
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
swiss_join and partition has been changed.
add an assertion to ensure that batch_prtn_ranges is incremented and relax the rows check of partition eval.
What changes are included in this PR?
swiss_join.cc
partition_util.h
Are these changes tested?
yes
Are there any user-facing changes?
yes