Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log-rotate): log rotate time align #6615

Closed
wants to merge 2 commits into from
Closed

fix(log-rotate): log rotate time align #6615

wants to merge 2 commits into from

Conversation

shuaijinchao
Copy link
Member

Description

FIX #6517
LINK #6521

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added in this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backwards compatible (If not, please discuss on the APISIX mailing list first)

@moonming
Copy link
Member

@shuaijinchao please do NOT directly copy and paste other people's PR(#6521) without discussing and reaching a consensus with other contributors.
I closed this PR. Please help @snowdusk to write test cases of #6521

@moonming moonming closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: log-rotate can not rotate logs strictly hourly(or minutely)
2 participants
@shuaijinchao @moonming