-
-
Notifications
You must be signed in to change notification settings - Fork 23.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for GitLab #1563
Comments
@NatoBoram, I like your feature request. However, I am not sure if it falls within the project scope that @anuraghazra envisioned. We are currently working on more pressing feature requests and bugs and are not implementing this shortly. However, if @anuraghazra thinks this is within the project scope, somebody can create a pull request for it. I will leave this issue open to check the support of the community. |
Would you accept a pull request for this? I might do this one day when I have some free time. |
@hamishmb I'm okay with a pull request if it does not complicate the codebase. We, however, are in the middle of a significant code overhaul; see #1633, so it might be easier to add this feature after that is done. I, however, will leave this decision to @anuraghazra since I'm not 100% sure if adding other git sites like GitLab/bitbucket etc., is within the original project vision. |
Okay, that seems fair, I shall wait for the overhaul to finish. |
@hamishmb, on the second tought, the changes in #1633 are related to the SVG and, therefore, would not conflict with your proposed PR too much since they are related to the fetchers. As a result, I think you can already implement this feature to use it on your fork. Whether the PR gets merged into the main branch depends on how much it complicates the codebase and @anuraghazra opinion. I am happy to review an implementation proposal to see if it complicates the codebase before you start to implement it. @anuraghazra, do you think supporting other Git providers like GitLab is in the project's scope, or would you prefer we stay at GitHub? |
Okay. It's probably going to be quite a while before I have the time/headspace anyway, so I'll probably still end up doing it afterwards. |
@hamishmb No hurries! I fully understand. We're all maintaining this project in our free time 💪. I just wanted to check with @anuraghazra before you implemented something that we will not merge. |
Oh yeah no worries all good, still good to have the information either way :) |
@NatoBoram thanks for the feature request. But I don't think we will be supporting GitLab.
|
Ah okay, that's totally fair enough. Thanks for making the enquiry for me though. |
@anuraghazra Makes sense! Maybe we can release the core (i.e. common) components as a |
Having this organizational structure greatly benefits the developability and open-source nature of the project since we have better permission management giving us the ability to have a larger team. We could also put the Proposed structure
|
Still doesn't solve the issue of where to run it, if your existing VM instance (or whatever it is) doesn't have any extra capacity. EDIT: But it sounds like a good idea, for other reasons as well as for this. |
@hamishmb correct it only splits the capacity over multiple Vercel instances, repositories and PATs. |
Out of interest, what is PAT? |
O sorry for using the abbreviation without any explanation. In this case, it refers to Github Personal Access Token (PAT). We use it in the public Vercel instance to interact with the GraphQL API (see #1772 and https://github.com/anuraghazra/github-readme-stats/blob/master/src/common/retryer.js). |
Excellent, thanks for telling me. I've done a little web development, so would need to learn more, but this might make a fun project someday 👍 |
I know this is a little old, but if #2409 gets merged, you can easily add GitLab stats, and perhaps create a PR too (maybe I will try doing it myself later on)! |
Amazing, GitLab support would be great! 👍 |
Is there any progress on this? |
It will be possible to implement after #2473 gets merged. |
The text was updated successfully, but these errors were encountered: