feat: chart update (#1739)

Co-authored-by: xuying.xu <xuying.xu@alibaba-inc.com>
antvis · Mar 1, 2023 · 839faba · 839faba
1 parent ca29507
commit 839faba
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/packages/f2/src/chart/index.tsx b/packages/f2/src/chart/index.tsx
@@ -146,10 +146,7 @@ class Chart<
 
   on(eventName: string, listener: (...args: any[]) => void) {
     this.gesture = this.gesture ? this.gesture : new Gesture(this.coordRef.current);
-    this.gesture.on(eventName, (ev) => {
-      const { x, y } = ev;
-      isInBBox(this.getCoord(), { x, y }) && listener(ev);
-    });
+    this.gesture.on(eventName, listener);
   }
 
   off(eventName: string, listener: (...args: any[]) => void) {

diff --git a/packages/f2/src/components/geometry/selection.ts b/packages/f2/src/components/geometry/selection.ts
@@ -46,16 +46,17 @@ class Selection<
   }
 
   didMount() {
-    const { props, state, context } = this;
+    const { props, state } = this;
     const { selection, chart } = props;
     if (!selection) return;
     // 默认为 click
     const { triggerOn = 'click' } = selection;
-    context.gesture.on(triggerOn, (ev) => {
+    chart.on(triggerOn, (ev) => {
       const { points, canvasX: x, canvasY: y } = ev;
       const point = triggerOn === 'click' ? { x, y } : points[0];
       const records = this.getSnapRecords(point);
       const { type = 'single', cancelable = true } = selection;
+
       if (!records || !records.length) {
         if (cancelable) {
           this.setState({

diff --git a/...tooltip/__image_snapshots__/tooltip-test-tsx-tooltip-tooltip-超出边界不响应-1-snap.png b/...tooltip/__image_snapshots__/tooltip-test-tsx-tooltip-tooltip-超出边界不响应-1-snap.png
diff --git a/...ltip/__image_snapshots__/tooltip-test-tsx-tooltip-tooltip-超出边界会展示边界值-1-snap.png b/...ltip/__image_snapshots__/tooltip-test-tsx-tooltip-tooltip-超出边界会展示边界值-1-snap.png
diff --git a/packages/f2/test/components/tooltip/tooltip.test.tsx b/packages/f2/test/components/tooltip/tooltip.test.tsx
@@ -245,7 +245,7 @@ describe('tooltip', () => {
     expect(context).toMatchImageSnapshot();
   });
 
-  it('Tooltip 超出边界不响应', async () => {
+  it('Tooltip 超出边界会展示边界值', async () => {
     const context = createContext('Tooltip 超出边界会展示边界值');
     const onChangeMockCallback = jest.fn();
     const { props } = (