-
-
Notifications
You must be signed in to change notification settings - Fork 50.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: responsiveObserve init miss sizing #20400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit 2ee7ebf |
Hmmm...... CI failed... |
@@ -77,6 +77,8 @@ const responsiveObserve = { | |||
mql, | |||
listener, | |||
}; | |||
|
|||
listener(mql); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样就好了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,初始化的时候就有一个默认值。之后 add 就是新的。 test case 里要调整一下。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
给力,测试代码也清晰多了。
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ee7ebf:
|
Codecov Report
@@ Coverage Diff @@
## 4.0-prepare #20400 +/- ##
===============================================
+ Coverage 97.57% 97.57% +<.01%
===============================================
Files 295 295
Lines 6754 6755 +1
Branches 1861 1822 -39
===============================================
+ Hits 6590 6591 +1
Misses 164 164
Continue to review full report at Codecov.
|
🤔 This is a ...
🔗 Related issue link
ref #20356
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge