Cargo improvements #7895
Open
Cargo improvements #7895
+587
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
felixfontein
added
check-before-release
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
aretrosen
force-pushed
the
cargo-improvements
branch
from
b6e0b0d to
324bf6a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aretrosen
force-pushed
the
cargo-improvements
branch
2 times, most recently
from
c47ef98 to
3c283ea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aretrosen
force-pushed
the
cargo-improvements
branch
2 times, most recently
from
73813af to
a56d543
Compare
ansibullbot
added
ci_verified
There was a problem hiding this comment.
Sorry for not commenting on this earlier. I was hoping that we can get #7363 in first, since it's preparing TOML support in a nicer way (IMO) and has been there longer. Unfortunately that seems to be stuck right now.
Please note that you have to add a changelog fragment.
Also, extending the tests (see tests/integration/targets/cargo/) would be nice.
|
|
||
| HAS_TOML = True | ||
| except ImportError: | ||
| pass |
There was a problem hiding this comment.
The TOML code should preferably be in a module utils, similar as in #7895.
ansibullbot
added
needs_revision
plugins/modules/cargo.py
Outdated
| version_added: 8.4.0 | ||
| all_features: | ||
| description: | ||
| - Enable all features for package(s). |
|
|
||
| HAS_TOML = True | ||
| except ImportError: | ||
| pass |
ansibullbot
added
the
needs_rebase
Co-authored-by: Felix Fontein <felix@fontein.de>
Use comma separated list of features without quotes
aretrosen
force-pushed
the
cargo-improvements
branch
from
a57166c to
d3856f3
Compare
ansibullbot
added
needs_revision
aretrosen
force-pushed
the
cargo-improvements
branch
from
0edaa4a to
e61f3fd
Compare
ansibullbot
removed
the
needs_revision
felixfontein
removed
the
backport-8
felixfontein
added
the
backport-9
ansibullbot
added
needs_rebase
colin-nolan
added a commit
to colin-nolan/community.general
that referenced
this pull request
Jun 9, 2024
felixfontein
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Fixes installed version for git/local. * Support latest determination with local source. * Adds docs. * Improves error message. * Setup for tests. * Updates copyright. * Align closer to #7895. * Adds changelog. * Check directory exists. * Stop using format strings. * Corrects directory arg type in docs. * Setup test repo dynamically. * Adds tests. * Adds version matching tests. * Update changelog fragment to match PR ID. * Updates copyright. * Import new directory tests.
patchback bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Fixes installed version for git/local. * Support latest determination with local source. * Adds docs. * Improves error message. * Setup for tests. * Updates copyright. * Align closer to #7895. * Adds changelog. * Check directory exists. * Stop using format strings. * Corrects directory arg type in docs. * Setup test repo dynamically. * Adds tests. * Adds version matching tests. * Update changelog fragment to match PR ID. * Updates copyright. * Import new directory tests. (cherry picked from commit 69b72e4)
felixfontein
pushed a commit
that referenced
this pull request
Jun 17, 2024
…urce in a given directory (#8527) `cargo` module install from source in a given directory (#8480) * Fixes installed version for git/local. * Support latest determination with local source. * Adds docs. * Improves error message. * Setup for tests. * Updates copyright. * Align closer to #7895. * Adds changelog. * Check directory exists. * Stop using format strings. * Corrects directory arg type in docs. * Setup test repo dynamically. * Adds tests. * Adds version matching tests. * Update changelog fragment to match PR ID. * Updates copyright. * Import new directory tests. (cherry picked from commit 69b72e4) Co-authored-by: Colin Nolan <colin-nolan@users.noreply.github.com>
felixfontein
removed
the
backport-9
|
Hi @aretrosen , Are you still planning to work on this? |
No, I am not working at it currently. Should I close the PR? |
|
If you want to keep it, it's OK - but we will ping you every once in a while to check on it. If this has dropped entirely from your plans, then yes, please close it. Unless someone wants to resume working on it, in which case they should step forward and pick it up. |
felixfontein
added
the
backport-10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Closes #7338
This supports almost all flags by cargo install.
Caveats:
Currently, many packages can be installed at all, but in this PR, only one can be installed at a time. Further work can be done to install multiple packages at a time, if the design is confirmed.ISSUE TYPE
COMPONENT NAME
community.general.cargo
ADDITIONAL INFORMATION