Skip to content

Commit

Permalink
Switch to to node 22.x
Browse files Browse the repository at this point in the history
  • Loading branch information
ssbarnea committed Dec 23, 2024
1 parent f137936 commit 88c339f
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .envrc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ export VIRTUAL_ENV="${HOME}/.local/share/virtualenvs/vsa"
# Reached heap limit Allocation failed - JavaScript heap out of memory
# https://nodejs.org/api/cli.html#--max-old-space-sizesize-in-megabytes
# default 16 MiB for 64-bit systems and 8 MiB for 32-bit systems
export NODE_OPTIONS="--max-old-space-size=8192"
# As MacOS gihub runners have only 14GB RAM, we should go go beyond 10GB heap
# https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners
export NODE_OPTIONS="--max-old-space-size=10240"

# Activate virtualenv (creates it if needed)
layout python3
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ jobs:
- name: task package
id: package
run: |
export NODE_OPTIONS="--max-old-space-size=8192"
task package ${{ matrix.env.TASKFILE_ARGS }}
- name: task ${{ matrix.task-name }}
Expand Down
7 changes: 4 additions & 3 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
direnv 2.34.0
nodejs 20.18.0
nodejs 22.12.0
# asdf install task latest
task 3.37.2
yarn 1.22.19
task 3.37.2
yarn 1.22.19
# npm latest
1 change: 1 addition & 0 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ tasks:
desc: Run UI tests {{.XVFB}}
aliases: [ui]
cmds:
- echo "NODE_OPTIONS=${NODE_OPTIONS}"
- yarn webpack-dev
- "{{.VIRTUAL_ENV}}/bin/python3 --version"
- bash -c 'rm -rf ./out/test-resources ./out/ext'
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,7 @@
"engineStrict": true,
"engines": {
"//": "node version affects only development, it does not affect VS Code runtime",
"node": ">=20.0",
"node": ">=22.12",
"npm": "\n\nERROR: Please use yarn instead of npm for this repository.!!!\n\n",
"vscode": "^1.85.0",
"yarn": ">=4.5.1"
Expand Down

0 comments on commit 88c339f

Please sign in to comment.