Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert notify related checks, errors, transforms for listen and tests #4205

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Revert notify related checks, errors, transforms for listen and tests #4205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d94ca4
Revert notify related checks, errors, transforms for listen and tests
audgirka Jun 4, 2024
e4be541
Removed unused code
audgirka Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed unused code
  • Loading branch information
@audgirka @ssbarnea
audgirka authored and ssbarnea committed Jun 4, 2024
commit e4be5412d7a24419c5a75e552b87a32f657c58cf
2 changes: 1 addition & 1 deletion .github/workflows/tox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
env:
# Number of expected test passes, safety measure for accidental skip of
# tests. Update value if you add/remove tests.
PYTEST_REQPASS: 882
PYTEST_REQPASS: 881
steps:
- uses: actions/checkout@v4
with:
Expand Down
11 changes: 0 additions & 11 deletions src/ansiblelint/rules/name.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,17 +347,6 @@ def test_rule_name_lowercase() -> None:
assert errs[0].tag == "name[casing]"
assert errs[0].rule.id == "name"

# def test_rule_notify_lowercase() -> None:
# """Negative test for a task notify that starts with lowercase."""
# collection = RulesCollection()
# collection.register(NameRule())
# failure = "examples/playbooks/name_case_notify_fail.yml"
# bad_runner = Runner(failure, rules=collection)
# errs = bad_runner.run()
# assert len(errs) == 5
# assert all(err.tag == "name[casing]" for err in errs)
# assert all(err.rule.id == "name" for err in errs)

def test_name_play() -> None:
"""Positive test for name[play]."""
collection = RulesCollection()
Expand Down
1 change: 0 additions & 1 deletion test/test_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ def fixture_runner_result(
id="strings",
),
pytest.param("examples/playbooks/vars/empty.yml", 1, False, True, id="empty"),
# pytest.param("examples/playbooks/name-case.yml", 6, True, True, id="name_case"),
pytest.param("examples/playbooks/fqcn.yml", 3, True, True, id="fqcn"),
pytest.param(
"examples/playbooks/multi_yaml_doc.yml",
Expand Down
Loading