Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(common): Update event emit in mock to reflect type #53660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(common): Update event emit in mock to reflect type #53660

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Dec 20, 2023

The MockPlatformLocation includes properties that do not exist on the public type of LocationChangeEvent. This commit removes these extra properties.

@atscott
refactor(common): Update even emit in mock to reflect type
66b2ad4 
The `MockPlatformLocation` includes properties that do not exist on the
public type of `LocationChangeEvent`. This commit removes these extra
properties.
@atscott atscott added area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Dec 20, 2023
@ngbot ngbot bot added this to the Backlog milestone Dec 20, 2023
@atscott atscott changed the title refactor(common): Update even emit in mock to reflect type refactor(common): Update event emit in mock to reflect type Jan 29, 2024
@atscott atscott marked this pull request as ready for review January 29, 2024 20:24
@atscott atscott added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbondwilkinson tbondwilkinson tbondwilkinson approved these changes

Assignees
No one assigned
Labels
area: common Issues related to APIs in the @angular/common package target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@atscott @tbondwilkinson