feat(common): support URL object in HttpClient #46470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the `URL` object in `HttpClient` and `HttpClientTestingBackend`. BREAKING CHANGE: Implementations of `HttpTestingController` have to support the `URL` object as well. Fixes angular#45497.
crisbeto
commented
Jun 23, 2022
| @@ -30,7 +30,8 @@ export abstract class HttpTestingController { | |||
| /** | |||
| * Search for requests that match the given parameter, without any expectations. | |||
| */ | |||
| abstract match(match: string|RequestMatch|((req: HttpRequest<any>) => boolean)): TestRequest[]; | |||
| abstract match(match: string|URL|RequestMatch| | |||
There was a problem hiding this comment.
I was on the fence on whether these changes are breaking since I've never seen anybody implement this class themselves. I played it safe since the class is marked as @publicApi.
crisbeto
added
action: review
josephperrott
added
detected: breaking change
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
URLobject inHttpClientandHttpClientTestingBackend.BREAKING CHANGE:
Implementations of
HttpTestingControllerhave to support theURLobject as well.Fixes #45497.