Skip to content

Commit

Permalink
build(http): Mark the http tests as flaky because of one particular…
Browse files Browse the repository at this point in the history
… transferCache test. (#55255)

There is one particular transfer cache test that seldom fails. Let's mark it as flaky for now as this issue is non-obvious.

PR Close #55255
  • Loading branch information
JeanMeche authored and pkozlowski-opensource committed Apr 11, 2024
1 parent c77ebb6 commit 051c140
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/common/http/test/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,15 @@ ts_library(
jasmine_node_test(
name = "test",
bootstrap = ["//tools/testing:node"],
flaky = True, # TODO: figure out why one of the transferCache tests is flaky
deps = [
":test_lib",
],
)

karma_web_test_suite(
name = "test_web",
flaky = True, # TODO: figure out why one of the transferCache tests is flaky
deps = [
":test_lib",
],
Expand Down
1 change: 1 addition & 0 deletions packages/common/http/test/transfer_cache_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ describe('TransferCache', () => {
makeRequestAndExpectOne('/test-1?foo=1', 'foo', {method: 'POST'});
});

// TODO: Investigate why this test is flaky
it('should cache POST with the transferCache option', () => {
makeRequestAndExpectOne('/test-1?foo=1', 'foo', {method: 'POST', transferCache: true});
makeRequestAndExpectNone('/test-1?foo=1', 'POST', {transferCache: true});
Expand Down

0 comments on commit 051c140

Please sign in to comment.