Happypack block #126

fenos · 2017-03-01T15:59:40Z

As discussed in the issue #14 will be very nice to have a happypack block wich allows us to easily implement Happypack features to improve the performance of the build.

@andywer found a neat way to implement the block using the webpack-block API, big thanks for that.

With a bit of delay I finish it up, so here you go.

module.exports = createConfig([
  happypack([
     babel(),
     sass(),
  ])
])

Note:
I'm using the loader for a while now, and unfortunately, I haven't seen any improvements in terms of build speed in either watch mode and production build This Pr will also help to debug the problem.

tb · 2017-03-09T21:08:17Z

packages/happypack/index.js

+ * Takes an array, a function or something falsy and returns the array, the
+ * function wrapped in an array or an empty array, respectively.
+ */
+function toArray(value) {https://github.com/fenos/webpack-blocks


https://github.com/fenos/webpack-blocks in code ??

😉

andywer · 2017-03-10T10:14:25Z

@tb Thanks :) And let's thank @github for letting the target repo owner edit files of PRs 😉

andywer · 2017-03-10T10:16:19Z

@amilajack We still need some proof that it works as expected, esp. due to the performance concern. Can we do anything to help testing it?

amilajack · 2017-03-10T15:36:38Z

@andywer What kind of testing would you like me to do? I can test this on some projects that I have that use webpack. Or do you want me to do performance testing?

andywer · 2017-03-10T16:01:10Z

Just some rudimentary testing. Does it work (I suppose so) and is it faster than without :)

fenos · 2017-03-10T16:36:00Z

@amilajack @andywer I'm preparing a small react repo with webpack-blocks so we can measure the performance

@andywer : thanks for fixing the copy typo

fenos · 2017-03-10T17:16:30Z

@andywer @amilajack I was trying to find a react starter trough github so that i could just swap the webpack config to webpack-block, they are all relatively small, the build takes less then 4.0sec, so is not realistic. However there I could see that happypack did improve performance of 1s.

So I'm wondering if there is something wrong with the webpack config that we are using, or maybe not.

If you could try it in a bigger project then would help

amilajack · 2017-03-21T06:04:16Z

@fenos A relatively big project that I would recommend is https://github.com/chentsulin/electron-react-boilerplate, which I am a maintainer of. In the project, we're having a lot of issues with slow build times. Also to have noticeable performance improvements, I think we have to add support for webpack caches and DLL's

andywer · 2017-03-28T11:42:25Z

Any news?

amilajack · 2017-03-28T20:26:45Z

Haven't had the chance to do this yet. I hope @fenos had a go at this

soda-x · 2017-03-31T06:43:30Z

Any news?

diegohaz · 2017-04-08T18:14:41Z

Hey, guys. FYI, I've just published webpack-blocks-happypack based on this PR.

It has a DISABLE_HAPPY env flag so we can easily test if it's actually improving build speed.

On my tests, I'm using it on ARc, which is a relatively small project, and these are the build times on my Mac (4 CPUs):

without happy: ~11.5s;
with happy and without cache: ~10.5s;
with happy and cache: ~9.5s.

ARc only uses babel-loader though.

I'm also using that on a bigger project at work with babel-loader and css-loader. Time decreased from ~40s to ~30s.

If this PR get merged, I can deprecate that. I'm also fine with maintaining it as I'm using it on big projects in production.

andywer · 2017-04-09T09:47:08Z

Hey @diegohaz. Sounds great, thank you!

We should look into that, esp. since it's already published.
And I promise I will come up with a community blocks list soon to keep track of all the awesome stuff that's not in the main repo 😉

sapegin · 2017-08-09T12:34:38Z

So what we’re going to do here? I’d close this PR, make a list of third-party blocks (already planned and needed) and link @diegohaz block there.

andywer · 2017-08-09T18:51:17Z

I agree with @sapegin

Happypack block

8cc08c5

tb reviewed Mar 9, 2017

View reviewed changes

amilajack mentioned this pull request Mar 10, 2017

Discussion: Webpack Blocks electron-react-boilerplate/electron-react-boilerplate#598

Closed

Fix the copy-paste incident

8792d96

😉

andywer closed this Aug 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Happypack block #126

Happypack block #126

fenos commented Mar 1, 2017

tb Mar 9, 2017 •

edited

Loading

andywer commented Mar 10, 2017

andywer commented Mar 10, 2017

amilajack commented Mar 10, 2017

andywer commented Mar 10, 2017

fenos commented Mar 10, 2017

fenos commented Mar 10, 2017 •

edited

Loading

amilajack commented Mar 21, 2017

andywer commented Mar 28, 2017

amilajack commented Mar 28, 2017

soda-x commented Mar 31, 2017

diegohaz commented Apr 8, 2017 •

edited

Loading

andywer commented Apr 9, 2017

sapegin commented Aug 9, 2017

andywer commented Aug 9, 2017

Happypack block #126

Happypack block #126

Conversation

fenos commented Mar 1, 2017

tb Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

andywer commented Mar 10, 2017

andywer commented Mar 10, 2017

amilajack commented Mar 10, 2017

andywer commented Mar 10, 2017

fenos commented Mar 10, 2017

fenos commented Mar 10, 2017 • edited Loading

amilajack commented Mar 21, 2017

andywer commented Mar 28, 2017

amilajack commented Mar 28, 2017

soda-x commented Mar 31, 2017

diegohaz commented Apr 8, 2017 • edited Loading

andywer commented Apr 9, 2017

sapegin commented Aug 9, 2017

andywer commented Aug 9, 2017

tb Mar 9, 2017 •

edited

Loading

fenos commented Mar 10, 2017 •

edited

Loading

diegohaz commented Apr 8, 2017 •

edited

Loading