-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax error in sankey.py #23
Comments
Fixed in pySankeyBeta, you can install it with :
|
Can you put this command in README ? |
@brianpenghe No, if I could merge, I would merge the correction directly ;) |
Well, if the pySankeyBeta is based on the github webpage I haven't tried the pysankey beta, but am going to try to modify my local copy of the library to see if I can't get the functionality I'm looking for. |
@kenosborne, PySankeyBeta is based on https://github.com/Pierre-Sassoulas/pySankey/tree/master. I'll be able to merge your pull request and release another version if you need. |
I've installed the pySankeyBeta but the error is still there |
It might still import the old one. Did you uninstall Do |
Yes I uninstalled PySankey. But when I reinstall pySankeyBeta again, it creates two folders under /usr/local/lib/python3.6/dist-packages/ : one for pySankeyBeta with no .py files in it, and one for pysankey with the older version. And when I do |
Can you also try |
Currently line 34 of sankey.py in the pySankey package is - if len(labels > 0):
When the leftLabels or rightLabels arguments are provided to the sankey function, this generates an error.
Line 34 should be updated to if len(labels) > 0:
The text was updated successfully, but these errors were encountered: