-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Update grow to v1.0.0 #5292
Merged
Merged
🎉 Update grow to v1.0.0 #5292
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
98b7489
:construction: Update imports
lluerich 9b80e67
:construction: Python3 specific changes
lluerich 15d2e27
:package: Update extension due to grow update
lluerich 277c77a
Merge branch 'future' into grow-1-update
lluerich 40cf73d
:mute: Remove additional logs
lluerich 12e3caa
:recycle: Join conditions
lluerich a163240
:recycle: Remove unneeded import
lluerich 5131d0b
🚧 Tentatively enable CI build
matthiasrohmer c2c2d03
🔧 Enable build stage on Travis CI
matthiasrohmer fd4f1a0
Merge branch 'grow-1-update' of github.com:ampproject/amp.dev into gr…
lluerich e7b2f63
📦 Add python3 to apt packages for Travis
matthiasrohmer 7523632
Merge branch 'grow-1-update' of github.com:ampproject/amp.dev into gr…
lluerich 769c242
🐛 Also install python3-pip as apt package
matthiasrohmer ac3842b
Merge branch 'grow-1-update' of github.com:ampproject/amp.dev into gr…
matthiasrohmer 9ca94a2
🚧 Install python3.5-complete instead of just python3
matthiasrohmer 5615d25
🚧 Try utilizing pyenv to update Python version
matthiasrohmer b28a169
🚧 Try to set CLOUDSDK_PYTHON for gsutil
matthiasrohmer 4470618
🎉 Use Grow 1 and Python 3 to build pages
matthiasrohmer de4d047
:construction: Adapt to python3 open()
lluerich 0e70139
Merge branch 'future' into grow-1-update
lluerich bf65697
:wrench: Enable full build on Travis CI
lluerich 31f2f05
Merge branch 'grow-1-update' of github.com:ampproject/amp.dev into gr…
lluerich 86ef68b
:wrench: Fix indentation
lluerich 4c70db1
🐛 Unquote $order key in document frontmatter
matthiasrohmer 935bc9e
🐛 Correct path for amp-animation reference documentation
matthiasrohmer 4439d58
🐛 Unquote remaining $order keys in documents
matthiasrohmer de085ad
👽 Gracefully handle encoding when rewriting TOC
matthiasrohmer 5a420a6
📝 Update instructions to use Grow 1 and Python 3
matthiasrohmer 0915e53
🔧 Update minimum required Grow version to 1
matthiasrohmer c03bce3
:alien: Fix style of code snippets
lluerich 3c896e4
Merge branch 'future' into grow-1-update
lluerich d0c78ff
⏪ Disable full builds for PRs again
matthiasrohmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
📦 Update extension due to grow update
- Loading branch information
commit 15d2e274a88d0410f02cfe24671be28c67341ed0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
import logging | ||
|
||
from grow import extensions | ||
from grow.common import logger | ||
from grow.common import logger, colors | ||
from grow.server import manager | ||
|
||
logger._get_logger = logger.get_logger | ||
|
@@ -29,9 +29,22 @@ def get_logger(name='pod'): | |
def print_server_ready_message(pod, host, port): | ||
home_doc = pod.get_home_doc() | ||
root_path = home_doc.url.path if home_doc and home_doc.exists else '/' | ||
url = 'http://{}:{}{}'.format(host, port, root_path) | ||
url_base = 'http://{}:{}/'.format(host, port) | ||
url_root = 'http://{}:{}{}'.format(host, port, root_path) | ||
logger.LOGGER.info('Grow started successfully.') | ||
return url | ||
|
||
messages = manager.ServerMessages() | ||
messages.add_message('Pod:', pod.root, colors.HIGHLIGHT) | ||
messages.add_message('Server:', url_root, colors.HIGHLIGHT) | ||
|
||
# Trigger the dev manager message hook. | ||
extra_urls = pod.extensions_controller.trigger( | ||
'dev_manager_message', messages.add_message, url_base, url_root) or [] | ||
|
||
messages.add_message( | ||
'Ready.', 'Press ctrl-c to quit.', colors.SUCCESS, colors.SUCCESS) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
|
||
return (url_root, extra_urls) | ||
|
||
manager.print_server_ready_message = print_server_ready_message | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the idea of this extension is to silence the startup log and we are not printing them anyway, this can be removed.