Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Update grow to v1.0.0 #5292

Merged
merged 32 commits into from
Feb 9, 2021
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
98b7489
:construction: Update imports
lluerich Feb 2, 2021
9b80e67
:construction: Python3 specific changes
lluerich Feb 2, 2021
15d2e27
:package: Update extension due to grow update
lluerich Feb 2, 2021
277c77a
Merge branch 'future' into grow-1-update
lluerich Feb 2, 2021
40cf73d
:mute: Remove additional logs
lluerich Feb 2, 2021
12e3caa
:recycle: Join conditions
lluerich Feb 2, 2021
a163240
:recycle: Remove unneeded import
lluerich Feb 2, 2021
5131d0b
🚧 Tentatively enable CI build
matthiasrohmer Feb 2, 2021
c2c2d03
🔧 Enable build stage on Travis CI
matthiasrohmer Feb 2, 2021
fd4f1a0
Merge branch 'grow-1-update' of github.com:ampproject/amp.dev into gr…
lluerich Feb 2, 2021
e7b2f63
📦 Add python3 to apt packages for Travis
matthiasrohmer Feb 2, 2021
7523632
Merge branch 'grow-1-update' of github.com:ampproject/amp.dev into gr…
lluerich Feb 3, 2021
769c242
🐛 Also install python3-pip as apt package
matthiasrohmer Feb 3, 2021
ac3842b
Merge branch 'grow-1-update' of github.com:ampproject/amp.dev into gr…
matthiasrohmer Feb 3, 2021
9ca94a2
🚧 Install python3.5-complete instead of just python3
matthiasrohmer Feb 3, 2021
5615d25
🚧 Try utilizing pyenv to update Python version
matthiasrohmer Feb 3, 2021
b28a169
🚧 Try to set CLOUDSDK_PYTHON for gsutil
matthiasrohmer Feb 3, 2021
4470618
🎉 Use Grow 1 and Python 3 to build pages
matthiasrohmer Feb 3, 2021
de4d047
:construction: Adapt to python3 open()
lluerich Feb 4, 2021
0e70139
Merge branch 'future' into grow-1-update
lluerich Feb 4, 2021
bf65697
:wrench: Enable full build on Travis CI
lluerich Feb 4, 2021
31f2f05
Merge branch 'grow-1-update' of github.com:ampproject/amp.dev into gr…
lluerich Feb 4, 2021
86ef68b
:wrench: Fix indentation
lluerich Feb 4, 2021
4c70db1
🐛 Unquote $order key in document frontmatter
matthiasrohmer Feb 8, 2021
935bc9e
🐛 Correct path for amp-animation reference documentation
matthiasrohmer Feb 8, 2021
4439d58
🐛 Unquote remaining $order keys in documents
matthiasrohmer Feb 8, 2021
de085ad
👽 Gracefully handle encoding when rewriting TOC
matthiasrohmer Feb 8, 2021
5a420a6
📝 Update instructions to use Grow 1 and Python 3
matthiasrohmer Feb 8, 2021
0915e53
🔧 Update minimum required Grow version to 1
matthiasrohmer Feb 8, 2021
c03bce3
:alien: Fix style of code snippets
lluerich Feb 8, 2021
3c896e4
Merge branch 'future' into grow-1-update
lluerich Feb 8, 2021
d0c78ff
⏪ Disable full builds for PRs again
matthiasrohmer Feb 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
📦 Update extension due to grow update
  • Loading branch information
lluerich committed Feb 2, 2021
commit 15d2e274a88d0410f02cfe24671be28c67341ed0
19 changes: 16 additions & 3 deletions pages/extensions/log_beautifier/log_beautifier.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import logging

from grow import extensions
from grow.common import logger
from grow.common import logger, colors
from grow.server import manager

logger._get_logger = logger.get_logger
Expand Down Expand Up @@ -29,9 +29,22 @@ def get_logger(name='pod'):
def print_server_ready_message(pod, host, port):
home_doc = pod.get_home_doc()
root_path = home_doc.url.path if home_doc and home_doc.exists else '/'
url = 'http://{}:{}{}'.format(host, port, root_path)
url_base = 'http://{}:{}/'.format(host, port)
url_root = 'http://{}:{}{}'.format(host, port, root_path)
logger.LOGGER.info('Grow started successfully.')
return url

messages = manager.ServerMessages()
messages.add_message('Pod:', pod.root, colors.HIGHLIGHT)
messages.add_message('Server:', url_root, colors.HIGHLIGHT)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the idea of this extension is to silence the startup log and we are not printing them anyway, this can be removed.


# Trigger the dev manager message hook.
extra_urls = pod.extensions_controller.trigger(
'dev_manager_message', messages.add_message, url_base, url_root) or []

messages.add_message(
'Ready.', 'Press ctrl-c to quit.', colors.SUCCESS, colors.SUCCESS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.


return (url_root, extra_urls)

manager.print_server_ready_message = print_server_ready_message

Expand Down