Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final feature push for amp.dev 1.0 #1377

Merged
merged 122 commits into from
Feb 7, 2019
Merged

Final feature push for amp.dev 1.0 #1377

Changes from 1 commit
Commits
Show all changes
122 commits
Select commit Hold shift + click to select a range
592a879
♻️ Rename component-help to help organism
matthiasrohmer Jan 30, 2019
cd087e5
🎨 Correct CTA hierarchy on sample manual
matthiasrohmer Jan 30, 2019
74843e0
✨ Add demo button to sample manual intro
matthiasrohmer Jan 30, 2019
450c662
💄 Make TOC for samples behave like on other pages
matthiasrohmer Jan 30, 2019
30845b1
🐛 Correctly link demo for samples
matthiasrohmer Jan 30, 2019
93a8f72
🐛 Render elementsAfterBody for sample preview
matthiasrohmer Jan 30, 2019
5ecedc2
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Jan 30, 2019
70a90ee
🔀 Fix corrupt merge in samplesBuilder.js
matthiasrohmer Jan 30, 2019
6d611d4
Merge branch 'future' into refactor/examples
matthiasrohmer Jan 31, 2019
5d36db7
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Jan 31, 2019
f643d1a
🍱 change and move assets
Jan 31, 2019
3e6a0dd
⚡️ Reenable caching for sample building
matthiasrohmer Jan 31, 2019
27da259
🍱 Update amp-accordion component reference stub
matthiasrohmer Jan 31, 2019
85eae93
🐛 Remove line break from link
matthiasrohmer Jan 31, 2019
7d9fe4c
🐛 Add code fences to amp-app-banner sample
matthiasrohmer Jan 31, 2019
ef45da2
🐛 Unwrap Tip from old ampstart markup
matthiasrohmer Jan 31, 2019
b6c8a81
💄 Evenly style sample CTAs
matthiasrohmer Jan 31, 2019
ddd0152
🐛 Combine spaces for samples more aggressively
matthiasrohmer Jan 31, 2019
d98f113
🎨 Make sample URLs lowercase
matthiasrohmer Jan 31, 2019
f35a3bf
✨ Add sample title to preview header
matthiasrohmer Jan 31, 2019
a5b8120
💄 Limit sample CTA width to 50%
matthiasrohmer Jan 31, 2019
4c214eb
🐛 Fix a lot of cross references
matthiasrohmer Jan 31, 2019
a3c36ac
Merge branch 'refactor/examples' into origin/future
matthiasrohmer Jan 31, 2019
875e09c
🍱 restyle html files in examples
Jan 31, 2019
4095fb5
🍱 correct examples/source/ html files
Feb 1, 2019
70319e8
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Feb 1, 2019
d70c559
Merge branch 'refactor/examples' of https://github.com/jungvonmatt/am…
matthiasrohmer Feb 1, 2019
00d705a
🍱 Fix references between docs
matthiasrohmer Feb 1, 2019
db4b261
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Feb 5, 2019
3b3b5a7
🐛 Update project prefix in examples manual
matthiasrohmer Feb 5, 2019
be89b31
♻️ Accomodate latest changes for TOC
matthiasrohmer Feb 5, 2019
38594d6
✨ Bring back embedded story previews
matthiasrohmer Feb 5, 2019
68f3455
🚚 Add analytics template from abe.com
matthiasrohmer Feb 5, 2019
335caca
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Feb 6, 2019
10425ac
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Feb 6, 2019
456fadb
♻️ Update example analytics template to fit new one
matthiasrohmer Feb 6, 2019
a9f87fb
🐛 Always load amp-bind for header and TOC
matthiasrohmer Feb 6, 2019
85b80b9
🐛 Add missing space in front of available formats
matthiasrohmer Feb 6, 2019
824ce50
🐛 Unwrap TOC to have it working
matthiasrohmer Feb 6, 2019
4fffd59
♻️ Use relative URLs to fetch playground documents
matthiasrohmer Feb 6, 2019
f8fb42b
💄 Hide playground links on mobile
matthiasrohmer Feb 6, 2019
0951c40
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Feb 6, 2019
bba147c
✨ Add missing component imports and analytics
matthiasrohmer Feb 6, 2019
21564ca
🚧 Work in progress: trying to add ui localization
Siregar Feb 6, 2019
1d2f961
⚡️ Do not put actual content into .po files
matthiasrohmer Feb 6, 2019
aa8448c
🌐 Bootrstap message files
matthiasrohmer Feb 6, 2019
0123bb0
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Feb 6, 2019
1a4cc9a
♻️ Extract format background from format-toggle
matthiasrohmer Feb 7, 2019
9136745
🐛 Add closing head tag to websites preview
matthiasrohmer Feb 7, 2019
134551e
💄 Overflow ellipsis for long header subtitle
matthiasrohmer Feb 7, 2019
321ad03
♻️ Use new format backgrounds in format-toggle
matthiasrohmer Feb 7, 2019
96d8ac2
✨ Add preview for ad samples
matthiasrohmer Feb 7, 2019
b9f7e96
🐛 Make window scroll instead of container for ads preview
matthiasrohmer Feb 7, 2019
535e87e
:bug: Fix header pixel moving issue.
sebil Feb 7, 2019
683d289
:bug: Correctly align burger-icon.
sebil Feb 7, 2019
189eea6
:bug: Using %23 instead of # in a data URI body.
sebil Feb 7, 2019
6048777
🌐 Add localization
Siregar Feb 7, 2019
19a802f
Merge branch 'origin/future' into feature/localization
Siregar Feb 7, 2019
beccea3
🚧 Begin filtering teaser overview pages
matthiasrohmer Feb 7, 2019
1aa10b3
🔊 Be more specific when logging failed filtered requests
matthiasrohmer Feb 7, 2019
cdb1bea
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
matthiasrohmer Feb 7, 2019
6b1f827
Merge branch 'origin/future' into refactor/examples
matthiasrohmer Feb 7, 2019
fe5bc2c
✨ Add draft property to tbd pages
Siregar Feb 7, 2019
d6c8877
:fire: Remove unused icon import.
sebil Feb 7, 2019
e704c2c
:art: Use existing close icon instead of new cross icon.
sebil Feb 7, 2019
79dc3fb
:fire: Delete new cross icon because of existing close icon.
sebil Feb 7, 2019
f3e6311
:lipstick: Add cursor to consent buttons.
sebil Feb 7, 2019
c7f4a0f
✨ Make transform_markdown publicly available
matthiasrohmer Feb 7, 2019
20db626
✨ Render inline and block tips in sample documentation
matthiasrohmer Feb 7, 2019
7574333
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
sebil Feb 7, 2019
7705694
:bento: Add new svg icons for guides and tutorials overview pages
Feb 7, 2019
387c94e
:speech_balloon: Add content for new guides and tutorials overview pages
Feb 7, 2019
e415b0e
:lipstick: Styles for guides and tutorials overview pages
Feb 7, 2019
d0d2a60
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
Feb 7, 2019
bf9cb78
🍱 Migrate Experimental Features article
matthiasrohmer Feb 7, 2019
e24312f
💄 Add cursor: pointer to button
matthiasrohmer Feb 7, 2019
095200c
✨ Add experiment toggle to sample documentation
matthiasrohmer Feb 7, 2019
addc14c
🐛 Do not render page wide analytics if amp-geo or ...
matthiasrohmer Feb 7, 2019
1f6815c
Merge pull request #192 from jungvonmatt/refactor/examples
matthiasrohmer Feb 7, 2019
059ba1a
Merge branch 'future' into origin/future
matthiasrohmer Feb 7, 2019
d2121e3
🐛 Use sub_navigation for collapsable state in burger
matthiasrohmer Feb 7, 2019
5f36ee2
:speech_balloon: Add new links
Feb 7, 2019
f34a7c8
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
sebil Feb 7, 2019
c88daaf
🍱 Link teasers for email landing page
matthiasrohmer Feb 7, 2019
5f4dcca
:speech_balloon: Add daily resources links
Feb 7, 2019
2d7130a
🐛 Do not fail if data-available-formats is not present
matthiasrohmer Feb 7, 2019
468af58
🐛 Only consider order in collection for progress
matthiasrohmer Feb 7, 2019
aec80d9
✨ Add featured teasers to landing page websites
matthiasrohmer Feb 7, 2019
7a2aeda
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
matthiasrohmer Feb 7, 2019
1c64c49
:bento: Add new icons.
sebil Feb 7, 2019
7c4daa0
:lipstick: Refine 404 page.
sebil Feb 7, 2019
b3a996d
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
sebil Feb 7, 2019
084055e
add french title
Feb 7, 2019
1c73d77
🎨 Consolidate removal of filtered content
matthiasrohmer Feb 7, 2019
50399d9
:bug: Replace wrongly declared links
Feb 7, 2019
c1e1999
🍱 Migrate common attributes article
matthiasrohmer Feb 7, 2019
1ccabef
🌐 Add more translations
Siregar Feb 7, 2019
72e9cac
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
matthiasrohmer Feb 7, 2019
19f1fef
Merge branch 'feature/localization' into origin/future
Siregar Feb 7, 2019
a7a33dd
🔥 Remove unused shared hints
matthiasrohmer Feb 7, 2019
c0bc1a8
:recycle: Rename 404 template to error and refine offline page.
sebil Feb 7, 2019
9377146
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
sebil Feb 7, 2019
dae7117
:bug: New decleration of wrong links
Feb 7, 2019
6b9ae3b
✨ Add featured documents to ads landing page
matthiasrohmer Feb 7, 2019
0436913
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
matthiasrohmer Feb 7, 2019
6723714
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
Feb 7, 2019
c92c9a0
⚡️ Only render draft items in sidebar for development
matthiasrohmer Feb 7, 2019
16fcf97
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
matthiasrohmer Feb 7, 2019
13b4ef2
:art: Clean media queries.
sebil Feb 7, 2019
d34297f
:art: Add br before rolling format on mobile.
sebil Feb 7, 2019
8e88936
:bug: New decleration of link targets
Feb 7, 2019
621de02
:bug: Add new link targets
Feb 7, 2019
7ddf7f5
🔥 Remove deprecated dropdown styles
matthiasrohmer Feb 7, 2019
b82e4a5
💄 Update format color gradients
matthiasrohmer Feb 7, 2019
8daab1e
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
matthiasrohmer Feb 7, 2019
3166687
:bug: Fix huge space in stage on large screens.
sebil Feb 7, 2019
ca42b6e
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
sebil Feb 7, 2019
01afc0d
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
matthiasrohmer Feb 7, 2019
b6fa043
add links to about sites
Feb 7, 2019
c525407
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
Feb 7, 2019
4eb46f7
:bug: Remove deprecated # and replace with %23
Feb 7, 2019
4823939
Merge branch 'origin/future' of https://github.com/jungvonmatt/amp.de…
Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🐛 Add code fences to amp-app-banner sample
  • Loading branch information
@matthiasrohmer
matthiasrohmer committed Jan 31, 2019
commit 7d9fe4c3356cf61b06061e615e85eceb35ae181e
9 changes: 6 additions & 3 deletions examples/source/components/amp-app-banner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,29 +79,32 @@
<!--
The custom app banner shows up in AMP Viewers. The banner action opens the document's canonical URL as deep-link inside the app:

```html
<amp-video width="1920" height="1080"
src="/video/amp-app-banner-android-app-installed.mp4"
layout="responsive"
controls>
</amp-video>
```

...and if the app is not installed, the banner action shows the app in the Play Store / App Store:

```html
<amp-video width="1920" height="1080"
src="/video/amp-app-banner-android-app-not-installed.mp4"
layout="responsive"
controls>
</amp-video>
```

-->

<!-- ## Testing -->
<!--
The `amp-app-banner` will only show in browsers that don't provide their own app install banner. This means Chrome on Android or Safari on iOS will not show the `amp-app-banner,` but the native install banner. For testing `amp-app-banner` you can open this page:

* **On a mobile device:** in browser without native install banner, e.g. [Firefox](https://play.google.com/store/apps/details?id=org.mozilla.firefox&hl=en_GB) on Android or [Chrome](https://itunes.apple.com/gb/app/chrome-web-browser-by-google/id535886823?mt=8) on iOS.
* **On Desktop:** in [mobile device emulation mode](https://developers.google.com/web/tools/chrome-devtools/device-mode/) append `#webview=1` to the [page URL](<%host%>/components/amp-app-banner/#webview=1). The other option is to use a custom user agent in mobile emulation mode, for example:

<pre>Mozilla/5.0 (iPhone; CPU iPhone OS 9_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) CriOS/51.000.21 Mobile/13B143 Safari/601.1</pre>
* **On Desktop:** in [mobile device emulation mode](https://developers.google.com/web/tools/chrome-devtools/device-mode/) append `#webview=1` to the [page URL](<%host%>/components/amp-app-banner/#webview=1). The other option is to use a custom user agent in mobile emulation mode, for example: `Mozilla/5.0 (iPhone; CPU iPhone OS 9_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) CriOS/51.000.21 Mobile/13B143 Safari/601.1`
-->

</body>
Expand Down